Fix mini-window controls alignment across multi-resolution monitors

[justinshannon]

Summary by CodeRabbit

• Refactor
  • Enhanced window positioning on multi-display setups to ensure the window aligns consistently with the active screen. This improvement refines how the system determines if the window is partially off-screen and adjusts its horizontal alignment accordingly, resulting in a more reliable and visually consistent user experience.

[coderabbitai]

Walkthrough

The changes update the logic in the CompactWindow.axaml.cs file. The window’s alignment is now determined using the working area of the current screen via Screens.ScreenFromPoint(Position). The previous approach using aggregated screen bounds has been removed. New conditions were introduced to check if the window is off the left or right edge of the current screen and adjust the horizontal alignment accordingly.

Changes

File(s) Changed	Change Summary
vATIS.Desktop/.../CompactWindow.axaml.cs	Replaced aggregated screen bounds logic with current screen's working area. Removed totalScreenBounds, totalLeft, and totalRight; added screenBounds and updated off-screen alignment conditions.

Sequence Diagram(s)

sequenceDiagram
    participant W as Window (CompactWindow)
    participant SM as ScreenManager
    participant AL as AlignmentLogic

    W->>SM: Get current screen using Position
    SM-->>W: Return current screen's working area (screenBounds)
    W->>AL: Evaluate window position with screenBounds
    AL-->>W: Return appropriate HorizontalAlignment (Left/Right)

Loading

Possibly related PRs

• Dynamically change mini-window window controls alignment based on window position #125: Adjusts the OnPositionChanged method in the same file to calculate screen boundaries and modify the HorizontalAlignment for window controls, directly relating to the alignment changes in this PR.

Poem

I’m a rabbit on the run,
Hopping through bounds, oh what fun!
No more mix-ups in screen space,
Just neat alignments in their place.
With carrot cheers and code so bright,
I celebrate each hop in delight!
🥕🐇

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

vATIS.Desktop/Ui/Windows/CompactWindow.axaml.cs (1)

83-96: Consider simplifying the alignment logic.

The alignment logic is correct but could be more concise.

Consider simplifying using an expression-bodied statement:

-        // Adjust alignment based on visibility
-        if (isRightOffScreen)
-        {
-            WindowControls.HorizontalAlignment = HorizontalAlignment.Left;
-        }
-        else if (isLeftOffScreen)
-        {
-            WindowControls.HorizontalAlignment = HorizontalAlignment.Right;
-        }
-        else
-        {
-            // Keep default alignment when fully visible
-            WindowControls.HorizontalAlignment = HorizontalAlignment.Right;
-        }
+        // Align controls to the left only when window is off the right edge
+        WindowControls.HorizontalAlignment = isRightOffScreen 
+            ? HorizontalAlignment.Left 
+            : HorizontalAlignment.Right;

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between da35280 and 8714220.

📒 Files selected for processing (1)

• vATIS.Desktop/Ui/Windows/CompactWindow.axaml.cs (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (5)

• GitHub Check: build (macos-latest)
• GitHub Check: Analyze (cpp)
• GitHub Check: build (windows-latest)
• GitHub Check: build (ubuntu-latest)
• GitHub Check: Analyze (csharp)

🔇 Additional comments (2)

vATIS.Desktop/Ui/Windows/CompactWindow.axaml.cs (2)

72-74: LGTM! Robust screen detection with proper null handling.

The code correctly retrieves the current screen and handles the case where no screen is found.

---

76-81: LGTM! Clear and accurate screen bounds calculation.

The code correctly uses the screen's working area and calculates window positions accurately.