Fix observed ATIS station letter color

[justinshannon]

Summary by CodeRabbit

• New Features
  • Enhanced dynamic text indicators now adjust in real time based on network connectivity, providing clearer and more responsive visual feedback to users.

[coderabbitai]

Walkthrough

The changes update the CompactWindow UI by adding a new XML namespace for networking and modifying the behavior properties of the blinking text. The BlinkingTextBehavior now includes an IsEnabled binding to the network connection status using an EnumToBoolConverter, while still retaining the original binding for IsBlinking. These modifications integrate network state into UI behavior management.

Changes

File	Change Summary
vATIS.Desktop/Ui/Windows/CompactWindow.axaml	- Added new XML namespace: xmlns:networking="using:Vatsim.Vatis.Networking" - Updated BlinkingTextBehavior: • Added IsEnabled binding to NetworkConnectionStatus with EnumToBoolConverter and a parameter for the connected status • Retained original IsBlinking binding to IsNewAtis

Sequence Diagram(s)

sequenceDiagram
    participant W as CompactWindow.axaml
    participant VM as AtisStationViewModel
    participant Conv as EnumToBoolConverter
    participant BTB as BlinkingTextBehavior

    W->>VM: Request NetworkConnectionStatus
    VM-->>W: Return network status
    W->>Conv: Convert network status (Connected) to bool
    Conv-->>W: Return boolean value
    W->>BTB: Set IsEnabled based on converted value
    W->>BTB: Set IsBlinking from IsNewAtis binding

Loading

Poem

In the code garden where changes take flight,
I hop through XML fields both day and night.
A new namespace sprouts, bold and bright,
While blinking texts now dance in network light.
Happy hops and tweaks—my joy's in plain sight! 🐇
Cheers to smooth connections and code so light!

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4f201a6 and c6190d8.

📒 Files selected for processing (1)

• vATIS.Desktop/Ui/Windows/CompactWindow.axaml (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (7)

• GitHub Check: build (macos-latest)
• GitHub Check: build (windows-latest)
• GitHub Check: Analyze (cpp)
• GitHub Check: Analyze (csharp)
• GitHub Check: build (ubuntu-latest)
• GitHub Check: Analyze (cpp)
• GitHub Check: Analyze (csharp)

🔇 Additional comments (2)

vATIS.Desktop/Ui/Windows/CompactWindow.axaml (2)

6-6: LGTM!

The networking namespace addition is properly structured and necessary for the NetworkConnectionStatus enum usage.

---

51-51: LGTM! Improved visual state management.

The updated BlinkingTextBehavior now properly coordinates with the connection status:

• Blinking is enabled only when connected
• Works in conjunction with the color converter to provide consistent visual feedback
• Maintains the original blinking behavior for new ATIS notifications

This change ensures a more coherent visual state representation.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.