Fix undetermined cloud layer, add automatic CB detection #131
Conversation
WalkthroughThis pull request refines the handling of cloud formatting by modifying the Changes
Sequence Diagram(s)sequenceDiagram
participant U as User
participant FV as FormattingView
participant VM as FormattingViewModel
participant S as SelectedStation
U->>FV: Input/update Automatic CB Detection values
FV->>VM: Bind and update properties (Text & Voice)
VM->>S: Apply changes (via ApplyChanges / HandleAtisStationChanged)
S-->>VM: Updated ATIS format returned
VM-->>FV: UI refresh with new values
sequenceDiagram
participant CN as CloudNode
participant L as CloudLayer
participant S as SelectedStation
CN->>CN: Call FormatCloudsText/Voice
alt Special Cumulonimbus Condition
CN->>CN: Check (Station is not FAA ATIS, layer.Amount is None, BaseHeight is null, Type is Cumulonimbus)
CN-->>Caller: Return predefined automatic detection string
else Standard Cloud Handling
CN->>CN: Validate cloud amount via AmountToString(layer.Amount)
alt Cloud amount not valid
CN-->>Caller: Return empty string
else
CN->>CN: Build template string with regex replacements
CN-->>Caller: Return formatted cloud string
end
end
Possibly related PRs
Suggested labels
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
vATIS.Desktop/Profiles/AtisFormat/Nodes/AutomaticCbDetection.cs (1)
11-33: Consider making properties immutable and adding validation.The class looks good but could be improved:
- Consider making properties immutable (init-only) since they represent configuration values
- Add null validation in constructor using ArgumentNullException.ThrowIfNull()
public class AutomaticCbDetection { public AutomaticCbDetection(string? text, string? voice) { + ArgumentNullException.ThrowIfNull(text); + ArgumentNullException.ThrowIfNull(voice); Text = text; Voice = voice; } - public string? Text { get; set; } + public string Text { get; init; } - public string? Voice { get; set; } + public string Voice { get; init; } }vATIS.Desktop/Atis/Nodes/CloudNode.cs (1)
161-165: Consider extracting duplicate CB detection logic.The CB detection logic is duplicated between FormatCloudsText and FormatCloudsVoice methods.
+private bool IsAutomaticCbDetection(CloudLayer layer) +{ + return !Station.IsFaaAtis && layer is + { Amount: CloudLayer.CloudAmount.None, BaseHeight: null, Type: CloudLayer.CloudType.Cumulonimbus }; +} private string FormatCloudsText(CloudLayer layer) { ArgumentNullException.ThrowIfNull(Station); - if (!Station.IsFaaAtis && layer is - { Amount: CloudLayer.CloudAmount.None, BaseHeight: null, Type: CloudLayer.CloudType.Cumulonimbus }) + if (IsAutomaticCbDetection(layer)) { return Station.AtisFormat.Clouds.AutomaticCbDetection.Text ?? "//////CB"; } // ... rest of the method } private string FormatCloudsVoice(CloudLayer layer, CloudLayer? ceiling) { ArgumentNullException.ThrowIfNull(Station); - if (!Station.IsFaaAtis && layer is - { Amount: CloudLayer.CloudAmount.None, BaseHeight: null, Type: CloudLayer.CloudType.Cumulonimbus }) + if (IsAutomaticCbDetection(layer)) { return Station.AtisFormat.Clouds.AutomaticCbDetection.Voice ?? "RADAR DETECTED C-B CLOUDS."; } // ... rest of the method }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
vATIS.Desktop/Atis/Nodes/CloudNode.cs(1 hunks)vATIS.Desktop/Profiles/AtisFormat/Nodes/AutomaticCbDetection.cs(1 hunks)vATIS.Desktop/Profiles/AtisFormat/Nodes/Clouds.cs(1 hunks)vATIS.Desktop/Ui/AtisConfiguration/FormattingView.axaml(1 hunks)vATIS.Desktop/Ui/ViewModels/AtisConfiguration/FormattingViewModel.cs(4 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (7)
- GitHub Check: build (macos-latest)
- GitHub Check: Analyze (cpp)
- GitHub Check: build (windows-latest)
- GitHub Check: Analyze (csharp)
- GitHub Check: build (ubuntu-latest)
- GitHub Check: Analyze (cpp)
- GitHub Check: Analyze (csharp)
🔇 Additional comments (8)
vATIS.Desktop/Profiles/AtisFormat/Nodes/Clouds.cs (1)
49-52: LGTM!The AutomaticCbDetection property is well-integrated with appropriate default values.
vATIS.Desktop/Atis/Nodes/CloudNode.cs (2)
104-108: LGTM! Clear condition for automatic CB detection.The condition correctly checks for non-FAA ATIS and CB detection.
110-113: Good error handling with early return.Early return pattern improves code readability.
vATIS.Desktop/Ui/AtisConfiguration/FormattingView.axaml (1)
583-589: LGTM! Well-structured UI controls.The automatic CB detection UI controls are:
- Well-organized in a logical section
- Have informative tooltips
- Use consistent styling
- Properly bound to view model properties
vATIS.Desktop/Ui/ViewModels/AtisConfiguration/FormattingViewModel.cs (4)
97-98: LGTM!The private backing fields for automatic CB detection follow the established pattern and are properly declared as nullable strings.
1064-1094: LGTM!The properties for automatic CB detection are well-implemented with:
- Clear XML documentation
- Proper use of ReactiveUI's
RaiseAndSetIfChanged- Consistent tracking of initialization state
- Consistent naming with other properties
1699-1707: LGTM!The
ApplyChangesmethod updates for automatic CB detection follow the established pattern and properly handle the synchronization of text and voice values with the selected station's format.
1888-1889: LGTM!The
HandleAtisStationChangedmethod updates for automatic CB detection properly initialize both text and voice values from the station's format, maintaining consistency with other property initializations.
Summary by CodeRabbit