Set minimum macOS version to 12

[justinshannon]

Summary by CodeRabbit

• Chores
  • Updated project configuration to enforce macOS version 12.0 as the minimum supported release.
  • Applied platform-specific linker settings for optimized builds.
  • Made minor formatting adjustments to improve build consistency.

[coderabbitai]

Walkthrough

The changes update the project's macOS compatibility settings. In NativeAudio/CMakeLists.txt, a new line is added within the APPLE-specific conditional to enforce a minimum macOS deployment target of 12.0. Similarly, vATIS.Desktop/vATIS.Desktop.csproj now includes a new ItemGroup (active for non-Debug macOS builds with osx-x64 or osx-arm64) that sets a linker argument to enforce the same minimum version, along with minor formatting tweaks. No public API declarations have been altered.

Changes

File(s)	Change Summary
NativeAudio/CMakeLists.txt, vATIS.Desktop/…csproj	Added configuration for macOS 12.0: In CMakeLists.txt, a deployment target line is inserted under the APPLE check, and in the csproj, a new ItemGroup adds a macOS linker argument (-mmacosx-version-min=12.0) for non-Debug builds with minor formatting improvements.

Poem

I hopped into code with glee,
Setting macOS limits as clear as can be,
A new line here and a tweak so neat,
My little changes make the build complete,
A rabbit’s cheer in every byte—oh, so sweet! 🐰✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3e58287 and a568c5a.

📒 Files selected for processing (2)

• NativeAudio/CMakeLists.txt (1 hunks)
• vATIS.Desktop/vATIS.Desktop.csproj (3 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (7)

• GitHub Check: build (macos-latest)
• GitHub Check: Analyze (cpp)
• GitHub Check: build (windows-latest)
• GitHub Check: Analyze (csharp)
• GitHub Check: build (ubuntu-latest)
• GitHub Check: Analyze (cpp)
• GitHub Check: Analyze (csharp)

🔇 Additional comments (3)

NativeAudio/CMakeLists.txt (1)

17-18: Set Minimum macOS Deployment Target Correctly
The newly added lines set the minimum macOS deployment target to "12.0" using the FORCE flag. This ensures that the built product will require macOS 12.0 or higher, aligning well with the PR objective.

vATIS.Desktop/vATIS.Desktop.csproj (2)

22-26: Add macOS-Specific Linker Argument
The new ItemGroup conditionally applied for non-Debug builds on osx-x64 or osx-arm64 correctly adds the linker argument -mmacosx-version-min=12.0. This change neatly complements the CMake configuration by enforcing the minimum macOS version during linking. The XML structure and condition syntax are appropriate.

---

73-75: Minor Formatting Adjustments
There are minor formatting tweaks (e.g., tilde-marked lines) observed later in the file (e.g., the closing tag on line 50 and the ProjectReference section on lines 83-84). These appear to be cosmetic changes for consistency and do not impact functionality.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.