Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(xo-lite/host): display pif information in side panel / add pif metrics store #8186

Open
wants to merge 4 commits into
base: lite/host-network-tab
Choose a base branch
from

Conversation

J0ris-K
Copy link
Contributor

@J0ris-K J0ris-K commented Dec 10, 2024

Description

display pif information in side panel / add pif metrics store

Screenshot

image

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

Review process

This 2-passes review process aims to:

  • develop skills of junior reviewers
  • limit the workload for senior reviewers
  • limit the number of unnecessary changes by the author
  1. The author creates a PR.
  2. Review process:
    1. The author assigns the junior reviewer.
    2. The junior reviewer conducts their review:
      • Resolves their comments if they are addressed.
      • Adds comments if necessary or approves the PR.
    3. The junior reviewer assigns the senior reviewer.
    4. The senior reviewer conducts their review:
      • If there are no unresolved comments on the PR → merge.
      • Otherwise, we continue with 3.
  3. The author responds to comments and/or makes corrections, and we go back to 2.

Notes:

  1. The author can request a review at any time, even if the PR is still a Draft.
  2. In theory, there should not be more than one reviewer at a time.
  3. The author should not make any changes:
    • When a reviewer is assigned.
    • Between the junior and senior reviews.

@J0ris-K J0ris-K changed the base branch from master to lite/host-network-tab December 10, 2024 16:20
@J0ris-K J0ris-K marked this pull request as draft December 10, 2024 16:20
@J0ris-K J0ris-K changed the title Lite/host network tab sidepanel feat(xo-lite): display pif information in side panel / add pif metrics store Dec 10, 2024
@J0ris-K J0ris-K self-assigned this Dec 10, 2024
@J0ris-K J0ris-K force-pushed the lite/host-network-tab-sidepanel branch 2 times, most recently from 630484b to 7570f9a Compare December 10, 2024 16:47
@J0ris-K J0ris-K force-pushed the lite/host-network-tab branch 2 times, most recently from 8406813 to a0ba86d Compare December 12, 2024 13:17
@J0ris-K J0ris-K force-pushed the lite/host-network-tab-sidepanel branch 3 times, most recently from 8d785d5 to 77deaf7 Compare December 12, 2024 14:19
@J0ris-K J0ris-K marked this pull request as ready for review December 12, 2024 14:21
@J0ris-K J0ris-K requested a review from OlivierFL December 12, 2024 14:21
@J0ris-K J0ris-K force-pushed the lite/host-network-tab branch from a0ba86d to 9ddb152 Compare December 12, 2024 20:09
@J0ris-K J0ris-K force-pushed the lite/host-network-tab-sidepanel branch from 77deaf7 to d0e0828 Compare December 12, 2024 20:18
@J0ris-K J0ris-K force-pushed the lite/host-network-tab branch from 9ddb152 to 2e181e3 Compare December 12, 2024 20:30
@J0ris-K J0ris-K force-pushed the lite/host-network-tab-sidepanel branch from d0e0828 to 96b5342 Compare December 12, 2024 20:34
@J0ris-K J0ris-K force-pushed the lite/host-network-tab branch from 2e181e3 to 98b38d2 Compare December 30, 2024 15:50
@J0ris-K J0ris-K changed the title feat(xo-lite): display pif information in side panel / add pif metrics store feat(xo-lite/host): display pif information in side panel / add pif metrics store Jan 2, 2025
@J0ris-K J0ris-K force-pushed the lite/host-network-tab branch from a8da493 to 2776068 Compare January 2, 2025 14:56
@J0ris-K J0ris-K force-pushed the lite/host-network-tab-sidepanel branch from 96b5342 to e0aee0b Compare January 2, 2025 14:59
@J0ris-K J0ris-K force-pushed the lite/host-network-tab branch from 2776068 to 0604061 Compare January 6, 2025 10:47
@J0ris-K J0ris-K force-pushed the lite/host-network-tab-sidepanel branch from 164d543 to b226f7f Compare January 6, 2025 12:50
@J0ris-K J0ris-K force-pushed the lite/host-network-tab-sidepanel branch from b226f7f to ee49e4d Compare January 6, 2025 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant