Skip to content

Commit

Permalink
Clean up
Browse files Browse the repository at this point in the history
  • Loading branch information
Alexey Tal committed Jan 16, 2025
1 parent dd62f45 commit 46c0113
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 10 deletions.
2 changes: 1 addition & 1 deletion src/py4vasp/_raw/data.py
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ class Exciton:
structure: Structure
"The atomic structure to represent the densities."
exciton_charge: VaspData
"The data of electronic charge and magnetization density."
"The data of exciton charge density."


@dataclasses.dataclass
Expand Down
3 changes: 1 addition & 2 deletions src/py4vasp/_raw/definition.py
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,6 @@ def selections(quantity):
required=raw.Version(6, 5),
file="vaspout.h5",
structure=Link("structure", "exciton"),
#structure=Link("structure", DEFAULT_SOURCE),
exciton_charge=f"{group}/exciton_charge",
)
#
Expand Down Expand Up @@ -532,7 +531,7 @@ def selections(quantity):
schema.add(
raw.Topology,
name="exciton",
required=raw.Version(6, 4),
required=raw.Version(6, 5),
ion_types="results/supercell/ion_types",
number_ion_types="results/supercell/number_ion_types",
)
Expand Down
13 changes: 6 additions & 7 deletions src/py4vasp/calculation/_exciton.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
import numpy as np

from py4vasp import _config, calculation, exception
from py4vasp._third_party import graph, view
from py4vasp._util import documentation, import_, index, select, slicing
from py4vasp._third_party import view
from py4vasp._util import documentation, import_, index, select
from py4vasp.calculation import _base, _structure

pretty = import_.optional("IPython.lib.pretty")
Expand All @@ -13,11 +13,10 @@
_INTERNAL = "1"

class Exciton(_base.Refinery, _structure.Mixin, view.Mixin):
"""This class accesses exciton densities of VASP.
The exciton charge density can be calculation in the BSE/TDHf calculation.
With this class you can extract exciton charge densities.
"""This class accesses exciton charge densities of VASP.
The exciton charge densities can be calculated via the BSE/TDHF algorithm in
VASP. With this class you can extract these charge densities.
"""

@_base.data_access
Expand Down Expand Up @@ -116,7 +115,7 @@ def _create_map(self):
excitons=self._raw_data.exciton_charge.shape[0]
map_ = {
str(choice): choice-1
for choice in range(1,excitons)
for choice in range(1,excitons+1)
}
return map_

Expand Down

0 comments on commit 46c0113

Please sign in to comment.