Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui/uploader): support remove button slot #1835

Merged
merged 3 commits into from
Dec 25, 2024
Merged

feat(ui/uploader): support remove button slot #1835

merged 3 commits into from
Dec 25, 2024

Conversation

chouchouji
Copy link
Member

Checklist

List of tasks you have already done and plan to do.

  • Fix linting errors
  • Tests have been added / updated (or snapshots)

Change information

Describe your modifications here.

Issues

The issues you want to close, formatted as close #1.

Related Links

Links related to this pr.

Copy link

vercel bot commented Dec 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
varlet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 25, 2024 8:04am
varlet-ui-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 25, 2024 8:04am

Copy link

pkg-pr-new bot commented Dec 25, 2024

Open in Stackblitz

@varlet/eslint-config

npm i https://pkg.pr.new/@varlet/eslint-config@1835

@varlet/import-resolver

npm i https://pkg.pr.new/@varlet/import-resolver@1835

@varlet/cli

npm i https://pkg.pr.new/@varlet/cli@1835

@varlet/preset-tailwindcss

npm i https://pkg.pr.new/@varlet/preset-tailwindcss@1835

@varlet/icons

npm i https://pkg.pr.new/@varlet/icons@1835

@varlet/preset-unocss

npm i https://pkg.pr.new/@varlet/preset-unocss@1835

@varlet/shared

npm i https://pkg.pr.new/@varlet/shared@1835

@varlet/touch-emulator

npm i https://pkg.pr.new/@varlet/touch-emulator@1835

@varlet/ui

npm i https://pkg.pr.new/@varlet/ui@1835

@varlet/use

npm i https://pkg.pr.new/@varlet/use@1835

@varlet/vite-plugins

npm i https://pkg.pr.new/@varlet/vite-plugins@1835

commit: 60a85e2

Copy link

codecov bot commented Dec 25, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.88%. Comparing base (9cbf3e4) to head (60a85e2).
Report is 2 commits behind head on dev.

Files with missing lines Patch % Lines
packages/varlet-ui/src/uploader/Uploader.vue 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1835      +/-   ##
==========================================
- Coverage   92.93%   92.88%   -0.05%     
==========================================
  Files         325      325              
  Lines        7584     7587       +3     
  Branches     1876     1876              
==========================================
- Hits         7048     7047       -1     
- Misses        471      475       +4     
  Partials       65       65              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cloudflare-workers-and-pages bot commented Dec 25, 2024

Deploying varlet with  Cloudflare Pages  Cloudflare Pages

Latest commit: 60a85e2
Status: ✅  Deploy successful!
Preview URL: https://26ec46a3.varlet.pages.dev
Branch Preview URL: https://feat-uploader.varlet.pages.dev

View logs

@haoziqaq
Copy link
Member

加上版本号,3.8.0。会与菜单选择器的级联模式一起发布。

@haoziqaq haoziqaq merged commit 859701d into dev Dec 25, 2024
9 of 11 checks passed
@chouchouji chouchouji deleted the feat-uploader branch December 25, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants