variscite_ubi: Do not export shell variables when not needed #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since this file is included by machine conf, means these variables make
into all kind of recipes e.g. native, nativesdk and that makes whole
sstate specific to the machine and not usable across other
projects/machines. e.g. if we have imx8 and imx6 dart based products it
results in recompiling everything for each of them and thus keep two
copies of sstate which is inefficient.
Fixes
bitbake-diffsigs -t m4-native do_configure
Task dependencies changed from:
...
changed items: frozenset({'UBINIZE_ARGS_256kbpeb', 'MKUBIFS_ARGS_128kbpeb', 'MKUBIFS_ARGS_256kbpeb', 'UBINIZE_ARGS_128kbpeb'})
Dependency on Variable MKUBIFS_ARGS_128kbpeb was removed
Dependency on Variable MKUBIFS_ARGS_256kbpeb was removed
Dependency on Variable UBINIZE_ARGS_128kbpeb was removed
Dependency on Variable UBINIZE_ARGS_256kbpeb was removed
Signed-off-by: Khem Raj <[email protected]>
|
This is needed on all branches btw. |
kraj
added a commit
to YoeDistro/meta-clang
that referenced
this pull request
Nov 22, 2023
The problem is in BSP layer [1], these variable should not be exported universally moreover its not needed as well. [1] varigit/meta-variscite-bsp-imx#36 This reverts commit 288f752.
3 tasks
kraj
added a commit
to kraj/meta-clang
that referenced
this pull request
Nov 22, 2023
The problem is in BSP layer [1], these variable should not be exported universally moreover its not needed as well. [1] varigit/meta-variscite-bsp-imx#36 This reverts commit 288f752.
|
@nsdrude I tested the patch on kirkstone and i see the following error: |
|
@kraj do you plan to fix this patch based on @FrancescoFerraro's feedback, or should we close this pull request? |
Can you attach full logs which has details about the failure ? |
@kraj I don't have full logs, but I assume they can be reproduced by applying your patch and following these instructions: https://variwiki.com/index.php?title=Yocto_Build_Release&release=mx6-yocto-kirkstone-5.15.71_2.2.0-v1.0 @FrancescoFerraro please update if you followed a different process. |
|
@nsdrude the followed process was as you wrote. I just updated the error messages due to i forgot one |
It has been fixed in poky upstream and also backported into kirkstone [1] So please build with latest [1] https://git.yoctoproject.org/poky/commit/?h=kirkstone&id=32dd3d59c250f916115b339c29aa4dbfe50a3235 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since this file is included by machine conf, means these variables make into all kind of recipes e.g. native, nativesdk and that makes whole sstate specific to the machine and not usable across other projects/machines. e.g. if we have imx8 and imx6 dart based products it results in recompiling everything for each of them and thus keep two copies of sstate which is inefficient.
Fixes
bitbake-diffsigs -t m4-native do_configure
Task dependencies changed from:
...
changed items: frozenset({'UBINIZE_ARGS_256kbpeb', 'MKUBIFS_ARGS_128kbpeb', 'MKUBIFS_ARGS_256kbpeb', 'UBINIZE_ARGS_128kbpeb'}) Dependency on Variable MKUBIFS_ARGS_128kbpeb was removed Dependency on Variable MKUBIFS_ARGS_256kbpeb was removed Dependency on Variable UBINIZE_ARGS_128kbpeb was removed Dependency on Variable UBINIZE_ARGS_256kbpeb was removed