Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update swift tools version to 5.8 #41

Merged
merged 3 commits into from
Sep 19, 2024

Conversation

GNMoseke
Copy link
Contributor

@GNMoseke GNMoseke commented Sep 10, 2024

As of queues 1.15, swift 5.8 is required to build. This package is still on 5.6, and vapor itself is also on 5.8.

Also updates the README accordingly.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@GNMoseke GNMoseke requested a review from 0xTim as a code owner September 10, 2024 15:42
Copy link
Member

@0xTim 0xTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@GNMoseke
Copy link
Contributor Author

Ah I did not think about CI - @0xTim do you have a preference on removing the 5.6/5.7 jobs altogether or bumping them up to 5.10?

@0xTim
Copy link
Member

0xTim commented Sep 19, 2024

@GNMoseke yeah just remove them and add jobs for 5.10 and 6.0

@gwynne
Copy link
Member

gwynne commented Sep 19, 2024

I've updated the CI more comprehensively (there were several other things that needed to be addressed) in #42

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@GNMoseke
Copy link
Contributor Author

Thanks @gwynne!

@gwynne gwynne merged commit a3dac0d into vapor:main Sep 19, 2024
11 checks passed
@gwynne gwynne added the semver-patch Internal changes only label Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-patch Internal changes only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants