-
-
Notifications
You must be signed in to change notification settings - Fork 82
updating error type to use computed properties #559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
heckj
wants to merge
1
commit into
vapor:main
Choose a base branch
from
heckj:computed-properties-for-error
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,16 +1,23 @@ | ||
|
||
public struct ConnectionPoolError: Error, Hashable { | ||
enum Base: Error, Hashable { | ||
@usableFromInline | ||
enum Base: Error, Hashable, Sendable { | ||
case requestCancelled | ||
case poolShutdown | ||
} | ||
|
||
private let base: Base | ||
@usableFromInline | ||
let base: Base | ||
|
||
@inlinable | ||
init(_ base: Base) { self.base = base } | ||
|
||
/// The connection requests got cancelled | ||
public static let requestCancelled = ConnectionPoolError(.requestCancelled) | ||
public static var requestCancelled: Self { | ||
ConnectionPoolError(.requestCancelled) | ||
} | ||
/// The connection requests can't be fulfilled as the pool has already been shutdown | ||
public static let poolShutdown = ConnectionPoolError(.poolShutdown) | ||
public static var poolShutdown: Self { | ||
ConnectionPoolError(.poolShutdown) | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this one now marked as
@inlinable
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't need to be, I was cargo-culting the pattern I saw in apple/swift-nio#3229, which added
@inlinable
to the initializers as well. I presumed that was helping with performance effects from inlining in that code, but I'm replicating that somewhat blindly.Happy to pull it back out.