-
-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix multiple array type mapping mistakes and add missing date and time array types #463
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #463 +/- ##
==========================================
- Coverage 61.82% 61.70% -0.12%
==========================================
Files 125 125
Lines 10019 10030 +11
==========================================
- Hits 6194 6189 -5
- Misses 3825 3841 +16
|
Note: There are no new tests because the effect of the missing mappings is not visible from within PostgresNIO itself; it affects PostgresKit due to hacks in that package which make atypical use of the array type mappings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would love if we could add an integration test, that writes and reads the new array types?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks good to me! Please revert the changes that are not core of this pr.
…nd _time), fix typos in the `macaddr8Array` and `datemultirange` types, and add missing array mappings for `timestamp` and `tstzrange`.
8e58f79
to
d28dd00
Compare
1182
(_date
akadateArray
) and1183
(_time
akatimeArray
).macaddr8Aray
, renaming it tomacaddr8Array
.macaddr8
anddatemultirange
.timestamp
andtstzrange
.