-
-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft: Removals for v2 #445
Draft
fabianfett
wants to merge
20
commits into
vapor:main
Choose a base branch
from
fabianfett:v2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianfett
added
semver-major
Breaks existing public API.
breaking
To fix this bug or implement this feature we must break API
labels
Dec 13, 2023
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #445 +/- ##
==========================================
+ Coverage 54.98% 63.47% +8.49%
==========================================
Files 127 77 -50
Lines 10155 8614 -1541
==========================================
- Hits 5584 5468 -116
+ Misses 4571 3146 -1425
|
# Conflicts: # Sources/PostgresNIO/Data/PostgresDataType.swift # Sources/PostgresNIO/Docs.docc/index.md # Sources/PostgresNIO/Message/PostgresMessage+Identifier.swift # Sources/PostgresNIO/New/PostgresChannelHandler.swift # Sources/PostgresNIO/Utilities/Exports.swift # Sources/PostgresNIO/Utilities/PostgresError+Code.swift # Tests/IntegrationTests/PostgresNIOTests.swift # Tests/PostgresNIOTests/New/Extensions/ConnectionAction+TestUtils.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking
To fix this bug or implement this feature we must break API
semver-major
Breaks existing public API.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick and dirty draft of the removals that we want to do for v2. Happy to split this into smaller prs (see commits).