Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various small fixes #117

Merged
merged 10 commits into from
Feb 10, 2025
Merged

Various small fixes #117

merged 10 commits into from
Feb 10, 2025

Conversation

fpseverino
Copy link
Member

@fpseverino fpseverino commented Feb 5, 2025

These changes are now available in 4.7.2

  • Add "ExistentialAny" Swift setting
  • Add linting, Windows, Musl and iOS to CI
  • Remove superfluous exclude of DocC catalog
  • Improve DocC docs
  • Remove test prefix from test function names

Benchmarks/Parser/AsyncSyncSequence.swift Show resolved Hide resolved
@@ -4,7 +4,7 @@ import Testing
@Suite("Form Data Decoding Tests")
Copy link
Contributor

@MahdiBM MahdiBM Feb 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not a change in this PR but just want to mention i don't like how we have:

@Suite("Form Data Decoding Tests")
struct FormDataDecodingTests {

It literally says the same "Form Data Decoding Tests" twice which is of little value.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It says "Form Data Decoding Tests" instead of "FormDataDecodingTests". It's a small thing, but readability improves.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I should specify that I'm referring to readability of the output during tests at runtime, not of the code.)

@penny-for-vapor
Copy link

penny-for-vapor bot commented Feb 7, 2025

Benchmark Report for db805b8

✅ Pull request has no significant performance differences ✅

Click to expand comparison result

Benchmark check running at 2025-02-10 12:37:53 UTC

The baseline 'Various small fixes' is EQUAL to the defined thresholds.

Click to expand benchmark result

Baseline 'Various small fixes'

Host '4be683e69b78' with 2 'aarch64' processors with 3 GB memory, running:
#23-Ubuntu SMP Mon Dec  9 23:51:16 UTC 2024

Parser

CollatingParserAllocations_256MiB

Metric p0 p25 p50 p75 p90 p99 p100 Samples
Malloc (total) (K) * 82 82 82 82 82 82 82 1

CollatingParserAllocations_Empty

Metric p0 p25 p50 p75 p90 p99 p100 Samples
Malloc (total) * 8 8 8 8 8 8 8 1

CollatingParserCPUTime_256MiB

Metric p0 p25 p50 p75 p90 p99 p100 Samples
Time (user CPU) (ms) * 530 540 551 551 560 560 560 20

StreamingParserAllocations_256MiB

Metric p0 p25 p50 p75 p90 p99 p100 Samples
Malloc (total) (K) * 82 82 82 82 82 82 82 1

StreamingParserAllocations_Empty

Metric p0 p25 p50 p75 p90 p99 p100 Samples
Malloc (total) * 6 6 6 6 6 6 6 1

StreamingParserCPUTime_256MiB

Metric p0 p25 p50 p75 p90 p99 p100 Samples
Time (user CPU) (ms) * 510 510 510 510 510 520 520 20

Serializer

100xSerializerCPUTime_1024Parts

Metric p0 p25 p50 p75 p90 p99 p100 Samples
Time (user CPU) (ms) * 210 210 210 220 220 220 220 20

SerializerAllocations_1024Parts

Metric p0 p25 p50 p75 p90 p99 p100 Samples
Malloc (total) * 3087 3087 3087 3087 3087 3087 3087 1

SerializerAllocations_Empty

Metric p0 p25 p50 p75 p90 p99 p100 Samples
Malloc (total) * 4 4 4 4 4 4 4 1

@gwynne
Copy link
Member

gwynne commented Feb 7, 2025

Can we also include the updated theme-settings.json for the DocC catalog? E.g.:

{
  "theme": {
    "aside": { "border-radius": "16px", "border-style": "double", "border-width": "3px" },
    "border-radius": "0",
    "button": { "border-radius": "16px", "border-width": "1px", "border-style": "solid" },
    "code":   { "border-radius": "16px", "border-width": "1px", "border-style": "solid" },
    "color": {
      "multipartkit": "#392048",
      "documentation-intro-fill":  "radial-gradient(circle at top, var(--color-multipartkit) 30%, #000 100%)",
      "documentation-intro-accent": "var(--color-multipartkit)",
      "documentation-intro-eyebrow": "white",
      "documentation-intro-figure": "white",
      "documentation-intro-title": "white",
      "logo-base":  { "dark": "#fff", "light": "#000" },
      "logo-shape": { "dark": "#000", "light": "#fff" },
      "fill":       { "dark": "#000", "light": "#fff" }
    },
    "icons": { "technology": "/multipartkit/images/vapor-multipartkit-logo.svg" }
  },
  "features": {
    "quickNavigation": { "enable": true },
    "i18n": { "enable": true }
  }
}

@gwynne gwynne added the semver-patch Internal changes only label Feb 10, 2025
@gwynne gwynne merged commit 46074f7 into vapor:main Feb 10, 2025
12 checks passed
@fpseverino fpseverino deleted the various branch February 10, 2025 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-patch Internal changes only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants