-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various small fixes #117
Various small fixes #117
Conversation
@@ -4,7 +4,7 @@ import Testing | |||
@Suite("Form Data Decoding Tests") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not a change in this PR but just want to mention i don't like how we have:
@Suite("Form Data Decoding Tests")
struct FormDataDecodingTests {
It literally says the same "Form Data Decoding Tests" twice which is of little value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It says "Form Data Decoding Tests" instead of "FormDataDecodingTests". It's a small thing, but readability improves.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(I should specify that I'm referring to readability of the output during tests at runtime, not of the code.)
Benchmark Report for db805b8✅ Pull request has no significant performance differences ✅ Click to expand comparison resultBenchmark check running at 2025-02-10 12:37:53 UTCThe baseline 'Various small fixes' is EQUAL to the defined thresholds. Click to expand benchmark resultBaseline 'Various small fixes'
ParserCollatingParserAllocations_256MiB
CollatingParserAllocations_Empty
CollatingParserCPUTime_256MiB
StreamingParserAllocations_256MiB
StreamingParserAllocations_Empty
StreamingParserCPUTime_256MiB
Serializer100xSerializerCPUTime_1024Parts
SerializerAllocations_1024Parts
SerializerAllocations_Empty
|
Can we also include the updated {
"theme": {
"aside": { "border-radius": "16px", "border-style": "double", "border-width": "3px" },
"border-radius": "0",
"button": { "border-radius": "16px", "border-width": "1px", "border-style": "solid" },
"code": { "border-radius": "16px", "border-width": "1px", "border-style": "solid" },
"color": {
"multipartkit": "#392048",
"documentation-intro-fill": "radial-gradient(circle at top, var(--color-multipartkit) 30%, #000 100%)",
"documentation-intro-accent": "var(--color-multipartkit)",
"documentation-intro-eyebrow": "white",
"documentation-intro-figure": "white",
"documentation-intro-title": "white",
"logo-base": { "dark": "#fff", "light": "#000" },
"logo-shape": { "dark": "#000", "light": "#fff" },
"fill": { "dark": "#000", "light": "#fff" }
},
"icons": { "technology": "/multipartkit/images/vapor-multipartkit-logo.svg" }
},
"features": {
"quickNavigation": { "enable": true },
"i18n": { "enable": true }
}
} |
These changes are now available in 4.7.2
test
prefix from test function names