Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RSA-OAEP to JWK algorithms to support decoding. #226

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Add RSA-OAEP to JWK algorithms to support decoding. #226

merged 1 commit into from
Jan 30, 2025

Conversation

madsodgaard
Copy link
Contributor

@madsodgaard madsodgaard commented Jan 23, 2025

These changes are now available in 5.1.2

Fixes an issue where a JWKS failed to decode because it also contains encryption keys and therefore alg such as RSA-OAEP.

This does not add support for the cipher, but at least it will allow us to decode JWKS to use for signing where we might not be able to remove the encryption keys from the remote JWKS.

@madsodgaard madsodgaard requested a review from ptoffy as a code owner January 23, 2025 18:06
@penny-for-vapor
Copy link

Benchmark Report

✅ Pull request has no significant performance differences ✅

Click to expand comparison result

Benchmark check running at 2025-01-30 13:52:32 UTC

The baseline '226/merge' is EQUAL to the defined thresholds.

Click to expand benchmark result

Baseline '226/merge'

Host 'b45864e73c6e' with 2 'aarch64' processors with 3 GB memory, running:
#23-Ubuntu SMP Mon Dec  9 23:51:16 UTC 2024

Signing

ES256

Metric p0 p25 p50 p75 p90 p99 p100 Samples
Malloc (total) * 169 169 203 237 271 373 611 2724
Memory (resident peak) (M) 26 27 27 27 27 27 27 2724

EdDSA

Metric p0 p25 p50 p75 p90 p99 p100 Samples
Malloc (total) * 117 117 117 117 117 117 119 4606
Memory (resident peak) (M) 26 26 26 26 26 26 26 4606

RSA

Metric p0 p25 p50 p75 p90 p99 p100 Samples
Malloc (total) * 239 239 239 248 248 248 248 730
Memory (resident peak) (M) 26 27 27 27 27 27 27 730

TokenLifecycle

ES256 Generated

Metric p0 p25 p50 p75 p90 p99 p100 Samples
Malloc (total) * 355 355 355 389 457 559 661 2202
Memory (resident peak) (M) 27 27 27 27 27 27 27 2202

ES256 PEM

Metric p0 p25 p50 p75 p90 p99 p100 Samples
Malloc (total) * 373 373 373 373 373 373 373 3383
Memory (resident peak) (M) 27 27 27 27 27 27 27 3383

EdDSA Coordinates

Metric p0 p25 p50 p75 p90 p99 p100 Samples
Malloc (total) * 323 323 323 323 323 323 323 3020
Memory (resident peak) (M) 27 27 27 27 27 27 27 3020

EdDSA Generated

Metric p0 p25 p50 p75 p90 p99 p100 Samples
Malloc (total) * 291 291 291 291 291 291 291 3045
Memory (resident peak) (M) 26 27 27 27 27 27 27 3045

RSA PEM

Metric p0 p25 p50 p75 p90 p99 p100 Samples
Malloc (total) * 436 436 436 445 445 445 445 691
Memory (resident peak) (M) 27 27 27 27 27 27 27 691

Verifying

ES256

Metric p0 p25 p50 p75 p90 p99 p100 Samples
Malloc (total) * 263 263 263 263 263 263 263 4308
Memory (resident peak) (M) 26 27 27 27 27 27 27 4308

EdDSA

Metric p0 p25 p50 p75 p90 p99 p100 Samples
Malloc (total) * 251 251 251 251 251 251 251 3498
Memory (resident peak) (M) 27 27 27 27 27 27 27 3498

RS256

Metric p0 p25 p50 p75 p90 p99 p100 Samples
Malloc (total) * 257 257 257 257 257 257 257 4439
Memory (resident peak) (M) 27 28 28 28 28 28 28 4439

@0xTim 0xTim added the semver-patch Internal changes only label Jan 30, 2025
@0xTim 0xTim merged commit 03f5013 into main Jan 30, 2025
13 checks passed
@0xTim 0xTim deleted the rsa-oaep branch January 30, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-patch Internal changes only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants