Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Penny comment on benchmark PRs #50

Merged
merged 2 commits into from
Jan 18, 2025
Merged

Make Penny comment on benchmark PRs #50

merged 2 commits into from
Jan 18, 2025

Conversation

ptoffy
Copy link
Member

@ptoffy ptoffy commented Jan 18, 2025

No description provided.

@ptoffy ptoffy requested a review from gwynne as a code owner January 18, 2025 08:58
@@ -29,6 +29,13 @@ jobs:
- name: Configure git
run: git config --global --add safe.directory "${GITHUB_WORKSPACE}"

- name: Get Penny token
Copy link
Collaborator

@MahdiBM MahdiBM Jan 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why so high though, I'd move it to right before the comment action.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you wish master

@ptoffy ptoffy requested a review from MahdiBM January 18, 2025 09:01
Copy link
Collaborator

@MahdiBM MahdiBM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@ptoffy ptoffy merged commit 10db1c3 into main Jan 18, 2025
11 checks passed
@ptoffy ptoffy deleted the penny-benchmarks branch January 18, 2025 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants