Badgeo #238
Badgeo #238
Conversation
|
p.s. GEO is complaining, ill rerun tests later |
There was a problem hiding this comment.
What is worse/better:
-adding all imports in the configuartion.smk, making a single list, but adding imports that are not always needed
-adding imports per rule, keeping the list clear, but having two dozen lists everywhere
Right now we use both systems partially. At least we should pick one and stick to it. My preference is to place all imports in configuration.smk (and maybe add a comment indicating in which rules it is used).
|
For me the most sensible is to put the imports above the file it is used. Including duplicate imports. This is the way it is done in 'normal' Python, and I think we should try to do things as Pythonic as possible since everything is based on it. |
What problem is the PR solving / What's new?
As described in #228
What did change
Checking for layout now happens both on the website as through the API. If the website is unambiguous then use website info, otherwise API. Did not seem to break anything so far on my part,