Refactor: SSH/SFTP Connections #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lewislarsen
added
refactor
|
This is currently a WIP with the basic implementation done. Further testing is needed, and to slowly migrate over parts of the codebase that use the more mock heavy style of connecting to this system. It should be an improvement and make it much more testable. This will take a while, but it should be a vast improvement and hopefully in the end I'll be happy with it. |
…ardbackup/vanguard into feat/redo_remote_server_connecting # Conflicts: # app/Services/RemoveSSHKey/RemoveSSHKeyService.php
|
Pretty happy with the progress so far. It needs to undergo more manual testing, and then I can think about moving the Backup SSH/SFTP connections over to it. Currently it's being used by any server checking mechanism and the remove SSH key feature. |
…ng' into feat/redo_remote_server_connecting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vanguard PR
Description
This is a refactor of how Vanguard communicates with Linux servers.
How Has This Been Tested?
Checklist: