Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Deprecated: explode(): Passing null to parameter #2 ($string) #39

Conversation

lewislarsen
Copy link
Member

Pull Request

Description

There was a bug that showed itself when the .ENV didn't have any admin email addresses set.

Per PHP 8.4 Passing null to parameter #2 ($string) of type string is deprecated which this PR aims to address.

Type of change

Please delete options that are not relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • [ ]

How Has This Been Tested?

  • Automated testing (Feature tests, Unit tests)
  • Manual testing

Checklist:

  • I have performed a self-review of my own code
  • My changes do not introduce any new warnings or errors
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • I have used translation helpers and provided translations (where appropriate)

Screenshots (if applicable):

Additional context

Add any other context or screenshots about the pull request here. Can remove this section if not necessary.

@lewislarsen lewislarsen merged commit 7a0725d into vanguardbackup:main Dec 29, 2024
6 checks passed
@lewislarsen lewislarsen deleted the fix/deprecated_function_parameter_fix branch December 29, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant