Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Two-factor authentication #23

Merged
merged 14 commits into from
Aug 16, 2024
Merged

Conversation

lewislarsen
Copy link
Member

Pull Request

Description

This Pull Requests adds two-factor-authentication support to Vanguard, the idea was a system similar to GitHub's and this is very much an initial implementation of the feature, eventually I would like to add more methods, but presently it only supports traditional app 6-digit-code auth.

This implementation also has email notifications for critical actions, such as enabling/disabling two-factor and so on.

Closes #21

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Automated testing (Feature tests, Unit tests)
  • Manual testing

Checklist:

  • I have performed a self-review of my own code
  • My changes do not introduce any new warnings or errors
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • I have used translation helpers and provided translations (where appropriate)

Screenshots (if applicable):

Here are a few screenshots of the feature so far.

CleanShot 2024-08-16 at 00 44 58

CleanShot 2024-08-16 at 00 45 11

CleanShot 2024-08-16 at 00 45 34

CleanShot 2024-08-16 at 00 46 55

Additional context

I have only added traditional app two-factor-authentication at this point, adding passkeys etc would be too much for this PR.

@lewislarsen lewislarsen self-assigned this Aug 15, 2024
@lewislarsen lewislarsen added enhancement New feature or request ui Pertains to the front-end UI aspect of the project. logic Pertains to the back-end logic aspect of the project. labels Aug 15, 2024
@lewislarsen lewislarsen marked this pull request as ready for review August 16, 2024 07:51
@lewislarsen lewislarsen merged commit 0d7127c into main Aug 16, 2024
9 checks passed
@lewislarsen lewislarsen deleted the feat/multi-factor-authentication branch August 16, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request logic Pertains to the back-end logic aspect of the project. ui Pertains to the front-end UI aspect of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Two Factor Authentication
1 participant