Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Check if test GUIDs are unique #3

Merged
merged 2 commits into from
Jun 3, 2024
Merged

chore: Check if test GUIDs are unique #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e9a99bc
chore: Check if test GUIDs are unique
vandjelk May 28, 2024
b67c28e
chore: Update test GUID
vandjelk May 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/pr-checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,3 +25,5 @@ jobs:
make test
- name: Check modified files
run: git diff --exit-code
- name: Check if test GUIDs are unique
run: x=$(grep -rEho '[[:xdigit:]]{8}(-[[:xdigit:]]{4}){3}-[[:xdigit:]]{12}' ./internal | sort | uniq -d); [ -z "${x}" ] || ( echo duplicated GUID detected $x; exit 1; )
2 changes: 1 addition & 1 deletion internal/controller/cloud-control/vpcpeering_aws_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ var _ = Describe("Feature: KCP VpcPeering", func() {
)
})

vpcpeeringName := "b76ff161-c288-44fa-a295-8df2076af6a5"
vpcpeeringName := "1839c399-c52e-4b43-b156-4b51027508cd"
vpcpeering := &cloudcontrolv1beta1.VpcPeering{}

By("When KCP VpcPeering is created", func() {
Expand Down
Loading