-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Web 3166 generic card component #558
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one! Thanks @nickbergquist
@methodog latest commit includes the updated :visited pseudoclass changes requested in the Jira ticket. On this note, I have removed the extraneous I have also made some changes to the properties of the text container so that it will correctly vertically contain any amount of content. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see my latest reply please
0c73b6c
to
c612caf
Compare
@methodog I had arranged these properties as we discussed last night but having rebased the present FB the new stylelint alphabetical ordering rule is kicking in. And regardless of our ordering intentions it has decided and enforced the order of properties which are now found in the latest commit! |
Ha! who can argue with the linters? |
https://vandam.atlassian.net/browse/WEB-3166