Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web 3166 generic card component #558

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

nickbergquist
Copy link
Contributor

@nickbergquist nickbergquist self-assigned this Dec 19, 2024
Copy link
Contributor

@methodog methodog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! Thanks @nickbergquist

@nickbergquist
Copy link
Contributor Author

@methodog latest commit includes the updated :visited pseudoclass changes requested in the Jira ticket. On this note, I have removed the extraneous color property in the b-icon-list component so that any icon-list blocks in the new cards can have colour controlled from within a container. In the absence of this the icon-list takes its color value from the body.

I have also made some changes to the properties of the text container so that it will correctly vertically contain any amount of content.

src/components/blocks/card/_card.scss Outdated Show resolved Hide resolved
Copy link
Contributor

@methodog methodog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see my latest reply please

@nickbergquist nickbergquist force-pushed the web-3166-generic-card-component branch from 0c73b6c to c612caf Compare January 16, 2025 12:05
@nickbergquist
Copy link
Contributor Author

see my latest reply please

@methodog I had arranged these properties as we discussed last night but having rebased the present FB the new stylelint alphabetical ordering rule is kicking in. And regardless of our ordering intentions it has decided and enforced the order of properties which are now found in the latest commit!

@methodog
Copy link
Contributor

Ha! who can argue with the linters?
Thanks @nickbergquist, i think the lint way makes good sense anyway, with the prefixed & standard versions of the equivalent property appearing next to each other - good for refactoring later when standards progress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants