Fix ownership on 'NextCallback' #191
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One big drawback of not passing the 'NextCallback' ownership forward is that it cannot be called after the callee has returned (e.g. in a thread or asynchronously). Make it owned across the whole 'perform_routing' recursion.
arteymix
force-pushed
the
fix-ownership-on-next
branch
from
5ed30b9
to
4605b4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One big drawback of not passing the 'NextCallback' ownership forward is that it cannot be called after the callee has returned (e.g. in a thread or asynchronously).
In the short-term, this is going to be really convenient to use threads for processing requests. It is necessary to build a threading middleware that would dispatch requests handling in a pool.
It's still bugging with the context being null, so there's some investigation to be performed.