feedback/audit

contracts/core/SharesFactoryV1.sol

@@ -2,8 +2,9 @@
 
 pragma solidity 0.8.25;
 
 import "@openzeppelin/contracts/access/Ownable2Step.sol";
 import "@openzeppelin/contracts/security/ReentrancyGuard.sol";
+import { SafeCastLib } from "solady/utils/SafeCastLib.sol";
 import { SafeERC20 } from "@openzeppelin/contracts/token/ERC20/utils/SafeERC20.sol";
 import { IERC20 } from "@openzeppelin/contracts/token/ERC20/IERC20.sol";
 import { IShare } from "../interface/IShare.sol";
@@ -88,7 +89,7 @@
     }
 
     function getSubTotal(uint32 fromSupply, uint32 quantity, uint8 curveType) public view returns (uint256) {
         (uint96 basePrice, uint32 inflectionPoint, uint128 inflectionPrice, uint128 linearPriceSlope,) = getCurve(curveType);
         return _subTotal(fromSupply, quantity, basePrice, inflectionPoint, inflectionPrice, linearPriceSlope);
     }
 
@@ -309,7 +310,7 @@
         uint256 fromSupply = IShare(ERC1155).shareFromSupply(shareId);
         uint256 actualReferralFeePercent = referral != address(0) ? referralFeePercent : 0;
 
-        buyPrice = getSubTotal(uint32(fromSupply), quantity, curveType);
+        buyPrice = getSubTotal(SafeCastLib.toUint32(fromSupply), quantity, curveType);
         referralFee = (buyPrice * actualReferralFeePercent) / 1 ether;
         creatorFee = (buyPrice * creatorFeePercent) / 1 ether;
         buyPriceAfterFee = buyPrice + referralFee + creatorFee;
@@ -341,7 +342,7 @@
         uint256 actualReferralFeePercent = referral != address(0) ? referralFeePercent : 0;
         require(fromSupply >= quantity, "Exceeds supply");
 
-        sellPrice = getSubTotal(uint32(fromSupply) - quantity, quantity, curveType);
+        sellPrice = getSubTotal(SafeCastLib.toUint32(fromSupply) - quantity, quantity, curveType);
         referralFee = (sellPrice * actualReferralFeePercent) / 1 ether;
         creatorFee = (sellPrice * creatorFeePercent) / 1 ether;
         sellPriceAfterFee = sellPrice - referralFee - creatorFee;

test/unit/SharesFactory.t.sol

@@ -2,6 +2,7 @@
 pragma solidity 0.8.25;
 
 import { console } from "forge-std/console.sol";
+import { SafeCastLib } from "solady/utils/SafeCastLib.sol";
 import { SharesFactoryV1 } from "contracts/core/SharesFactoryV1.sol";
 import { IYieldAggregator } from "contracts/interface/IYieldAggregator.sol";
 import { BaseTest } from "../BaseTest.t.sol";
@@ -92,11 +93,6 @@ contract SharesFactoryTests is BaseTest {
         assertEq(bobShareBal, 2);
     }
 
-    function test_buyShareWithHighVolume() public view {
-        (uint256 buyPriceAfterFee,,,) = sharesFactory.getBuyPriceAfterFee(0, 100000, referralReceiver);
-        console.log("test_buyShareWithHighVolume", buyPriceAfterFee);
-    }
-
     function test_sellShares() public {
         uint256 aliceBalBefore = addrAlice.balance;
         uint256 bobBalBefore = addrBob.balance;
@@ -385,6 +381,19 @@ contract SharesFactoryTests is BaseTest {
     }
 
     function test_getBuyPriceAfterFeeFailed() public {
+        // When the quantity is 5_000 that reach th
+        uint256 gasBefore = gasleft();
+        sharesFactory.getBuyPriceAfterFee(0, 5_000, referralReceiver);
+        uint256 gasAfter = gasleft();
+        console.log("gas usage", gasBefore - gasAfter);
+
+        // Expect revert if supply is over `2**32 -1` (uint32)
+        vm.expectRevert();
+        sharesFactory.getSubTotal(SafeCastLib.toUint32(2**32), 1, 0);
+
+        // Expect success if supply is lower than `2**32` (uint32)
+        sharesFactory.getSubTotal(SafeCastLib.toUint32(2**32 - 1), 1, 0);
+
         vm.expectRevert(bytes("Invalid shareId"));
         sharesFactory.getBuyPriceAfterFee(999, 0, referralReceiver);
 
@@ -525,7 +534,6 @@ contract SharesFactoryTests is BaseTest {
 
     function _buyShare(address sender, uint256 shareId, uint32 quantity, address referral) internal {
         (uint256 buyPriceAfterFee,,,) = sharesFactory.getBuyPriceAfterFee(shareId, quantity, referral);
-        // console.log("buyPriceAfterFee", buyPriceAfterFee, shareId, quantity, referral);
         vm.prank(address(sender));
         sharesFactory.buyShare{ value: buyPriceAfterFee }(shareId, quantity, referral);
     }