story/fix-fvm-dropdown update fvm only when component was focused and blurred, and data was changed during that time #1313
+47
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… blurred, and data was changed during that time
...ects/valtimo/form-view-model/src/lib/components/form-view-model/form-view-model.component.ts
Outdated
Show resolved
Hide resolved
...ects/valtimo/form-view-model/src/lib/components/form-view-model/form-view-model.component.ts
Outdated
Show resolved
Hide resolved
| @@ -162,6 +165,29 @@ export class FormViewModelComponent implements OnInit { | |||
| } else { | |||
| this.loadInitialViewModel(); | |||
| } | |||
|
|
|||
| this.focus$.pipe() | |||
There was a problem hiding this comment.
Add this to a Subscription and unsubscribe OnDestroy
| }) | ||
| }) | ||
|
|
||
| this.updateForm.pipe(filter(it => it), debounceTime(500)).subscribe(() => { |
There was a problem hiding this comment.
Add this to a Subscription and unsubscribe OnDestroy
…model/form-view-model.component.ts Co-authored-by: teodor-ritense <[email protected]>
…model/form-view-model.component.ts Co-authored-by: teodor-ritense <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes
Bug exists where in FVM, when you open a dropdown box it fires an onBlur event, which refreshes the form.
This in turn hides the dropdown select box, making it impossible for the user to select a value.
This changes the logic to only update the form when the data was changed between component focus and blur
Breaking changes
Documentation
Link to the pull request in the
Valtimo documentation repository:
New features or changes that have been introduced have been documented.