Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add demo mode entry in onboarding screen #6453

Merged
merged 11 commits into from
Jan 31, 2025
Merged

Conversation

kathaypacific
Copy link
Collaborator

@kathaypacific kathaypacific commented Jan 27, 2025

Description

The scope of this PR is limited to:

  1. adding dynamic config to support launching and displaying demo mode
  2. adding the entry point in onboarding to launch demo mode
  3. displaying the app with some indication that demo mode is active (I've added the gradient border for now)

Test plan

(It's not clear in the video but for the first 5 seconds, I am long pressing the logo)

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2025-01-31.at.10.41.08.mp4

Related issues

Backwards compatibility

Y

Network scalability

If a new NetworkId and/or Network are added in the future, the changes in this PR will:

  • Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)

Sorry, something went wrong.

custom: {
startOnboardingTime: startOnboardingTimeSelector(state),
startOnboardingTime: state.account.startOnboardingTime,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removing these selectors allowed me to break the cyclical dependency of statsig -> walletAddressSelector in src/web3/selectors -> statsig. this cycle was causing the imports from statsig to be undefined, which caused tests to fail (since you cannot pass undefined to createSelector). i don't see any problems with having no userID / the previous userID during demo mode

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 94.23077% with 3 lines in your changes missing coverage. Please review.

Project coverage is 89.09%. Comparing base (bfef6e8) to head (5760b10).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/web3/reducer.ts 0.00% 2 Missing ⚠️
src/onboarding/welcome/Welcome.tsx 95.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #6453   +/-   ##
=======================================
  Coverage   89.09%   89.09%           
=======================================
  Files         730      730           
  Lines       31827    31872   +45     
  Branches     5771     5780    +9     
=======================================
+ Hits        28355    28397   +42     
- Misses       3426     3429    +3     
  Partials       46       46           
Files with missing lines Coverage Δ
src/navigator/NavigatorWrapper.tsx 72.64% <100.00%> (+1.64%) ⬆️
src/redux/migrations.ts 97.01% <100.00%> (+<0.01%) ⬆️
src/redux/store.ts 89.23% <ø> (ø)
src/statsig/constants.ts 100.00% <ø> (ø)
src/statsig/types.ts 100.00% <100.00%> (ø)
src/web3/actions.ts 100.00% <100.00%> (ø)
src/web3/selectors.ts 100.00% <100.00%> (ø)
test/schemas.ts 91.83% <100.00%> (+0.02%) ⬆️
src/onboarding/welcome/Welcome.tsx 96.96% <95.00%> (-0.99%) ⬇️
src/web3/reducer.ts 75.00% <0.00%> (-10.72%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfef6e8...5760b10. Read the comment docs.

Copy link
Member

@jeanregisser jeanregisser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 🚀

@kathaypacific kathaypacific added this pull request to the merge queue Jan 31, 2025
Merged via the queue into main with commit a733bde Jan 31, 2025
16 checks passed
@kathaypacific kathaypacific deleted the kathy/demo-mode-1 branch January 31, 2025 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants