-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add demo mode entry in onboarding screen #6453
Conversation
src/statsig/index.ts
Outdated
custom: { | ||
startOnboardingTime: startOnboardingTimeSelector(state), | ||
startOnboardingTime: state.account.startOnboardingTime, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removing these selectors allowed me to break the cyclical dependency of statsig -> walletAddressSelector in src/web3/selectors -> statsig. this cycle was causing the imports from statsig to be undefined, which caused tests to fail (since you cannot pass undefined to createSelector
). i don't see any problems with having no userID / the previous userID during demo mode
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6453 +/- ##
=======================================
Coverage 89.09% 89.09%
=======================================
Files 730 730
Lines 31827 31872 +45
Branches 5771 5780 +9
=======================================
+ Hits 28355 28397 +42
- Misses 3426 3429 +3
Partials 46 46
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! 🚀
Description
The scope of this PR is limited to:
Test plan
(It's not clear in the video but for the first 5 seconds, I am long pressing the logo)
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2025-01-31.at.10.41.08.mp4
Related issues
Backwards compatibility
Y
Network scalability
If a new NetworkId and/or Network are added in the future, the changes in this PR will: