Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(accordion): add container switcher #6153

Draft
wants to merge 6 commits into
base: development
Choose a base branch
from

Conversation

SvetlanaMuravlova
Copy link
Contributor

@SvetlanaMuravlova SvetlanaMuravlova commented May 27, 2021

Feature: replace the wrapper div of the accordion for styling
refs #4092

@valorkin valorkin temporarily deployed to ngx-bootstra-accordion--vvgrxj May 27, 2021 12:07 Inactive
@codecov
Copy link

codecov bot commented May 27, 2021

Codecov Report

Merging #6153 (ac65452) into development (2224b5f) will increase coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #6153      +/-   ##
===============================================
+ Coverage        75.78%   75.89%   +0.11%     
===============================================
  Files              344      315      -29     
  Lines            10822    10643     -179     
  Branches          2575     2935     +360     
===============================================
- Hits              8201     8078     -123     
+ Misses            2611     2564      -47     
+ Partials            10        1       -9     
Impacted Files Coverage Δ
src/accordion/accordion-group.component.html 100.00% <100.00%> (ø)
src/accordion/accordion-group.component.ts 93.54% <100.00%> (+6.45%) ⬆️
...picker/themes/bs/bs-custom-dates-view.component.ts 60.00% <0.00%> (-20.00%) ⬇️
src/datepicker/utils/bs-calendar-utils.ts 74.68% <0.00%> (-16.75%) ⬇️
src/sortable/sortable.component.ts 5.55% <0.00%> (-13.34%) ⬇️
src/dropdown/bs-dropdown.directive.ts 78.08% <0.00%> (-11.29%) ⬇️
src/tooltip/tooltip.directive.ts 57.04% <0.00%> (-7.30%) ⬇️
src/timepicker/reducer/timepicker.reducer.ts 86.00% <0.00%> (-6.00%) ⬇️
src/timepicker/timepicker.component.ts 87.70% <0.00%> (-5.12%) ⬇️
src/modal/modal.directive.ts 4.00% <0.00%> (-4.72%) ⬇️
... and 194 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2224b5f...ac65452. Read the comment docs.

@github-actions
Copy link

github-actions bot commented May 27, 2021

Visit the preview URL for this PR (updated for commit ac65452):

https://ngx-bootstrap-demo--pr6153-accordion-replace-di-gdg4eb5m.web.app

(expires Wed, 02 Feb 2022 12:51:16 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@cypress
Copy link

cypress bot commented May 27, 2021



Test summary

799 33 14 0


Run details

Project ngx-bootstrap
Status Failed
Commit ef17700 ℹ️
Started Jan 26, 2022 12:52 PM
Ended Jan 26, 2022 1:29 PM
Duration 37:05 💡
OS Linux Ubuntu - 20.04
Browser Electron 93

View run in Cypress Dashboard ➡️


Failures

typeahead_page_spec.ts Failed
1 Typeahead demo page testing suite > On blur > clicking anywhere outside auto-fills "Option on blur" with the first option from the matches list
datepicker/locales_spec.ts Failed
1 Datepicker demo testing suite: Locales > Change Locale Datepicker > when user chose locale es-pr for "Datepicker", container shown in appropriate language
2 Datepicker demo testing suite: Locales > Change Locale DateRangepicker > when user chose locale es-pr for "Daterangepicker", container shown in this language
modals_service_page_spec.ts Failed
1 Modals demo page testing suite: Service examples > Component modals with interceptor > when user clicks on "No" button, doesn't close the modal
2 Modals demo page testing suite: Service examples > Nested modals > when user clicks on the button "Open second modal" then the second modal with title "Second modal" is opened, "Close self" is present
3 Modals demo page testing suite: Service examples > Events > when user closes modal by click on the cross then should be messages "onHide event has been fired" and "onHidden event has been fired"
4 Modals demo page testing suite: Service examples > Events > when user closes modal by pressing ESC button then modal is closed and should be messages "onHide event has been fired" and "onHidden event has been fired"
5 Modals demo page testing suite: Service examples > Confirm Window > when user clicks on "Open modal" button then modal is opened, it contains two buttons: "Yes" and "No"
6 Modals demo page testing suite: Service examples > Custom css class > when user clicks on the cross button then the modal is closed
7 Modals demo page testing suite: Service examples > Animation option > when user clicks on the cross button then the modal is closed
This comment includes only the first 10 test failures. See all 33 failures in the Cypress Dashboard.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@SvetlanaMuravlova SvetlanaMuravlova marked this pull request as draft May 27, 2021 12:18
@SvetlanaMuravlova SvetlanaMuravlova linked an issue May 28, 2021 that may be closed by this pull request
@SvetlanaMuravlova SvetlanaMuravlova marked this pull request as ready for review May 28, 2021 11:17
@SvetlanaMuravlova SvetlanaMuravlova marked this pull request as draft June 7, 2021 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(feature) accordion replace div
2 participants