Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(datepicker): add greek language translation (#5575) #5737

Open
wants to merge 4 commits into
base: development
Choose a base branch
from

Conversation

dimitrismitsiou
Copy link

@dimitrismitsiou dimitrismitsiou commented Mar 31, 2020

Add el - greek support

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.
  • added/updated API documentation.
  • added/updated demos.

@codecov
Copy link

codecov bot commented Mar 31, 2020

Codecov Report

Merging #5737 (92394f3) into development (c0beddb) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #5737      +/-   ##
===============================================
- Coverage        77.55%   77.51%   -0.04%     
===============================================
  Files              302      302              
  Lines            10549    10549              
  Branches          2583     2583              
===============================================
- Hits              8181     8177       -4     
- Misses            2358     2362       +4     
  Partials            10       10              
Impacted Files Coverage Δ
src/chronos/i18n/pl.ts 85.00% <0.00%> (-3.34%) ⬇️
src/chronos/i18n/sk.ts 85.13% <0.00%> (-1.36%) ⬇️
src/chronos/i18n/cs.ts 87.64% <0.00%> (-1.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0beddb...92394f3. Read the comment docs.

@daniloff200
Copy link
Contributor

@dimitrismitsiou thanks for the contribution!
I will review this PR tomorrow :)

Copy link
Contributor

@daniloff200 daniloff200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, looks good, but, you have to import that to the module, to the locale.ts file , and, of course, we need a unit tests for it

Check these PRs, to see, how it should look, as an examples:

https://github.com/valor-software/ngx-bootstrap/pull/5685/files
https://github.com/valor-software/ngx-bootstrap/pull/5556/files
https://github.com/valor-software/ngx-bootstrap/pull/4812/files
https://github.com/valor-software/ngx-bootstrap/pull/5551/files

@cypress
Copy link

cypress bot commented Jul 29, 2021



Test summary

87 0 6 0


Run details

Project ngx-bootstrap
Status Passed
Commit e3e5ad7 ℹ️
Started Jul 29, 2021 9:01 PM
Ended Jul 29, 2021 9:05 PM
Duration 04:40 💡
OS Linux Ubuntu - 20.04
Browser Electron 87

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants