-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(datepicker): add greek language translation (#5575) #5737
base: development
Are you sure you want to change the base?
feat(datepicker): add greek language translation (#5575) #5737
Conversation
Add el - greek support
Codecov Report
@@ Coverage Diff @@
## development #5737 +/- ##
===============================================
- Coverage 77.55% 77.51% -0.04%
===============================================
Files 302 302
Lines 10549 10549
Branches 2583 2583
===============================================
- Hits 8181 8177 -4
- Misses 2358 2362 +4
Partials 10 10
Continue to review full report at Codecov.
|
@dimitrismitsiou thanks for the contribution! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, looks good, but, you have to import that to the module, to the locale.ts file , and, of course, we need a unit tests for it
Check these PRs, to see, how it should look, as an examples:
https://github.com/valor-software/ngx-bootstrap/pull/5685/files
https://github.com/valor-software/ngx-bootstrap/pull/5556/files
https://github.com/valor-software/ngx-bootstrap/pull/4812/files
https://github.com/valor-software/ngx-bootstrap/pull/5551/files
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
Add el - greek support
PR Checklist
Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.