Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

option to disable git packaging for adhoc execution #313

Merged
merged 4 commits into from
Aug 30, 2024
Merged

option to disable git packaging for adhoc execution #313

merged 4 commits into from
Aug 30, 2024

Conversation

Kenneth-Schroeder
Copy link
Contributor

should resolve #122

akx
akx previously requested changes Aug 29, 2024
View reviewed changes
Copy link
Member

@akx akx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I think a positive argument that's set to true by default, and can be disabled with a negative flag, would be more intuitive.

NB: I didn't test the suggestions locally, so they might be wrong :)

valohai_cli/commands/deployment/create_version/create_version.py Outdated Show resolved Hide resolved
valohai_cli/commands/deployment/create_version/create_version.py Outdated Show resolved Hide resolved
valohai_cli/commands/deployment/create_version/create_version.py Outdated Show resolved Hide resolved
valohai_cli/commands/execution/run/frontend_command.py Outdated Show resolved Hide resolved
valohai_cli/commands/execution/run/frontend_command.py Outdated Show resolved Hide resolved
valohai_cli/commands/execution/run/frontend_command.py Outdated Show resolved Hide resolved
valohai_cli/commands/pipeline/run/run.py Outdated Show resolved Hide resolved
valohai_cli/commands/pipeline/run/run.py Outdated Show resolved Hide resolved
valohai_cli/commands/pipeline/run/run.py Outdated Show resolved Hide resolved
@Kenneth-Schroeder
Copy link
Contributor Author

Thank you, good feedback, I am not familiar with click :)

@akx akx enabled auto-merge (squash) August 30, 2024 11:19
@akx akx requested review from a team, teroyks and memona008 and removed request for a team August 30, 2024 11:19
@akx akx dismissed their stale review August 30, 2024 11:19

Recused since I fixed stuff & added tests :)

@akx akx requested review from hylje and removed request for akx August 30, 2024 11:19
teroyks
teroyks approved these changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@teroyks teroyks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and the test agrees.

@akx akx merged commit 6513931 into valohai:master Aug 30, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teroyks teroyks teroyks approved these changes

@akx akx akx left review comments

@memona008 memona008 Awaiting requested review from memona008 memona008 was automatically assigned from valohai/dev

@hylje hylje Awaiting requested review from hylje

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Submodules in ad-hoc runs
3 participants
@Kenneth-Schroeder @akx @teroyks