Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rax size tracking #688

Merged
merged 29 commits into from
Oct 2, 2024
Merged

Rax size tracking #688

merged 29 commits into from
Oct 2, 2024

Commits on Jun 25, 2024

  1. Track rax allocation size in rax header 

    Signed-off-by: Guillaume Koenig <[email protected]>
    @yzhaon @knggk
    yzhaon authored and knggk committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    12578aa View commit details
    Browse the repository at this point in the history

  2. fix use after free, don't update the alloc field in raxFree 

    Signed-off-by: Guillaume Koenig <[email protected]>
    @yzhaon @knggk
    yzhaon authored and knggk committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    aaebb31 View commit details
    Browse the repository at this point in the history

  3. Fix issues with previous attempt 

    Signed-off-by: Guillaume Koenig <[email protected]>
    @knggk
    knggk committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    e09bef3 View commit details
    Browse the repository at this point in the history

  4. Add rax-test from antirez repo into Redis repo 

    Signed-off-by: Guillaume Koenig <[email protected]>
    @yzhaon @knggk
    yzhaon authored and knggk committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    1acaa41 View commit details
    Browse the repository at this point in the history

  5. replace rc4rand with twin prime generator 

    Signed-off-by: Guillaume Koenig <[email protected]>
    @yzhaon @knggk
    yzhaon authored and knggk committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    9ac6f88 View commit details
    Browse the repository at this point in the history

  6. Replace usage of libc alloc fn calls with zmalloc calls 

    Signed-off-by: Guillaume Koenig <[email protected]>
    @yzhaon @knggk
    yzhaon authored and knggk committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    2de1d2e View commit details
    Browse the repository at this point in the history

  7. Remove time function, remove argv parsing code 

    Signed-off-by: Guillaume Koenig <[email protected]>
    @yzhaon @knggk
    yzhaon authored and knggk committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    4909a1f View commit details
    Browse the repository at this point in the history

  8. Add features of the unit test as flags 

    Signed-off-by: Guillaume Koenig <[email protected]>
    @yzhaon @knggk
    yzhaon authored and knggk committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    eeb0f2e View commit details
    Browse the repository at this point in the history

  9. Fix rax-test so that it compiles and tests pass 

    Signed-off-by: Guillaume Koenig <[email protected]>
    @knggk
    knggk committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    88cbb16 View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2024

  1. Move rax-test.c under src/unit/test_rax.c 

    Signed-off-by: Guillaume Koenig <[email protected]>
    @knggk
    knggk committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    f66ba88 View commit details
    Browse the repository at this point in the history

  2. Adapt rax tests to the new unit test framework 

    Signed-off-by: Guillaume Koenig <[email protected]>
    @knggk
    knggk committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    77f1b07 View commit details
    Browse the repository at this point in the history

  3. s/rax->alloc/rax->alloc_size/ 

    Signed-off-by: Guillaume Koenig <[email protected]>
    @knggk
    knggk committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    6cf1d96 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2024

  1. Tentative fix for address sanitizer 

    Signed-off-by: Guillaume Koenig <[email protected]>
    @knggk
    knggk committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    11a5a4f View commit details
    Browse the repository at this point in the history

  2. Fix missing zfree for src/valkey-unit-tests --large-memory 

    Signed-off-by: Guillaume Koenig <[email protected]>
    @knggk
    knggk committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    da095ac View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2024

  1. Reduce scope of variable 

    Signed-off-by: Guillaume Koenig <[email protected]>
    @knggk
    knggk committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    581fdbe View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2024

  1. s/rax_alloc_size/rax_ptr_alloc_size/ 

    Signed-off-by: Guillaume Koenig <[email protected]>
    @knggk
    knggk committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    a254c28 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2024

  1. Demo checking rax size vs allocator 

    Signed-off-by: Guillaume Koenig <[email protected]>
    @knggk
    knggk committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    59169c0 View commit details
    Browse the repository at this point in the history

  2. More testing of raxAllocSize against the allocator's number 

    Signed-off-by: Guillaume Koenig <[email protected]>
    @knggk
    knggk committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    540d2cf View commit details
    Browse the repository at this point in the history

  3. Update some checks into asserts with the new framework 

    Signed-off-by: Guillaume Koenig <[email protected]>
    @knggk
    knggk committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    212ac68 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2024

  1. Fix confusion that led to test failing 

    Signed-off-by: Guillaume Koenig <[email protected]>
    @knggk
    knggk committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    9f94fdb View commit details
    Browse the repository at this point in the history

  2. Apply clang-format 

    Signed-off-by: Guillaume Koenig <[email protected]>
    @knggk
    knggk committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    5f903fe View commit details
    Browse the repository at this point in the history

  3. Attempt at fixing spellcheck 

    Signed-off-by: Guillaume Koenig <[email protected]>
    @knggk
    knggk committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    ea3e33c View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2024

  1. Update src/unit/test_rax.c 

    Co-authored-by: Viktor Söderqvist <[email protected]>
Signed-off-by: Guillaume Koenig <[email protected]>
    @knggk @zuiderkwast
    knggk and zuiderkwast authored Jul 11, 2024
    Configuration menu
    Copy the full SHA
    f25969b View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2024

  1. Add rax into test names for better visualization 

    Signed-off-by: Guillaume Koenig <[email protected]>
    @knggk
    knggk committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    93b6b57 View commit details
    Browse the repository at this point in the history

  2. Plug raxAllocSize to mem reporting spots 

    Signed-off-by: Guillaume Koenig <[email protected]>
    @knggk
    knggk committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    b2c3383 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/unstable' into rax-size-tracking 

    Signed-off-by: Guillaume Koenig <[email protected]>
    @knggk
    knggk committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    7a889ae View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2024

  1. Merge remote-tracking branch 'origin/unstable' into rax-size-tracking

    @knggk
    knggk committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    eed12f2 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2024

  1. Merge remote-tracking branch 'origin/unstable' into rax-size-tracking

    @knggk
    knggk committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    6b72c68 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2024

  1. Fix formatting 

    Signed-off-by: Guillaume Koenig <[email protected]>
    @knggk
    knggk committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    fee849d View commit details
    Browse the repository at this point in the history