-
Notifications
You must be signed in to change notification settings - Fork 693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce CLUSTER SLOT-STATS command (#20). #351
Conversation
Run:
To fix the DCO complaint. |
The command provides detailed slot usage statistics upon invocation, with initial support for key-count metric. cpu-usec (approved) and memory-bytes (pending-approval) metrics will soon follow after the merger of this PR. Signed-off-by: Kyle Kim <[email protected]>
605c923
to
e17019b
Compare
Thanks for sharing. Two changes added;
|
@PingXie I think you asked for this in the past, you should also take a look if you have time. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## unstable #351 +/- ##
============================================
+ Coverage 70.05% 70.12% +0.06%
============================================
Files 110 111 +1
Lines 60084 60203 +119
============================================
+ Hits 42094 42218 +124
+ Misses 17990 17985 -5
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I remember most of this, and it still mostly LGTM.
Review this during a separate meeting.
Still need alignment about the command arguments. Will have separate approval for that. |
- Renamed cluster_slots.c to cluster_slot_stats.c - Renamed function signature and variables. - Removed 0 argument support. Signed-off-by: Kyle Kim <[email protected]>
I've cut a 2nd revision, which includes;
@PingXie @madolson |
- Update reply_schema. Signed-off-by: Kyle Kim <[email protected]>
@kyle-yh-kim Can you do a git merge and resolve the conflicts. Also please open a PR like valkey-io/valkey-doc#143 to add documentation for it. |
Signed-off-by: Kyle Kim <[email protected]>
- Fixed origin/unstable merge conflicts. - Updated formatting. - Updated cluster-slot-stats.json. Signed-off-by: Kyle Kim <[email protected]>
- Fixed format based on clang-format. - Re-added crccombine.o into Makefile. Signed-off-by: Kyle Kim <[email protected]>
- Valkey PR link; valkey-io/valkey#351. Signed-off-by: Kyle Kim <[email protected]>
- Valkey PR link; valkey-io/valkey#351. Signed-off-by: Kyle Kim <[email protected]>
PR for Valkey-doc has been opened; valkey-io/valkey-doc#150 |
- Valkey PR link; valkey-io/valkey#351. Signed-off-by: Kyle Kim <[email protected]>
- Updated RESP reply from map to array. - Renamed slotStatEntry to slotStatForSort. Signed-off-by: Kyle Kim <[email protected]>
2a8c171
to
12730f0
Compare
- Updated the RESP3 response from array of maps to array of arrays. Signed-off-by: Kyle Kim <[email protected]>
Signed-off-by: Madelyn Olson <[email protected]>
Signed-off-by: Madelyn Olson <[email protected]>
Signed-off-by: Madelyn Olson <[email protected]>
Docs for CLUSTER SLOT-STATS, with key-count, cpu-usec, network-bytes-in, and network-bytes-out metrics. - valkey-io/valkey#351 - valkey-io/valkey#712 - valkey-io/valkey#720 --------- Signed-off-by: Kyle Kim <[email protected]> Signed-off-by: Madelyn Olson <[email protected]> Signed-off-by: Viktor Söderqvist <[email protected]> Co-authored-by: Madelyn Olson <[email protected]> Co-authored-by: Viktor Söderqvist <[email protected]>
The command provides detailed slot usage statistics upon invocation, with initial support for key-count metric. cpu-usec (approved) and memory-bytes (pending-approval) metrics will soon follow after the merger of this PR.