-
Notifications
You must be signed in to change notification settings - Fork 634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename #include guards. #167
Conversation
Signed-off-by: Lipeng Zhu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, only one minor issue, Thanks
@@ -2,8 +2,8 @@ | |||
* It contains alternative structs which omit the parts of the commands table | |||
* that are not suitable for redis-cli, e.g. the command proc. */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* that are not suitable for redis-cli, e.g. the command proc. */ | |
* that are not suitable for valkey-cli, e.g. the command proc. */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hwware Let's leave it for another PR and we change only one thing in each PR. It is faster and more clear.
@@ -2,8 +2,8 @@ | |||
* It contains alternative structs which omit the parts of the commands table | |||
* that are not suitable for redis-cli, e.g. the command proc. */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hwware Let's leave it for another PR and we change only one thing in each PR. It is faster and more clear.
Signed-off-by: Viktor Söderqvist <[email protected]>
Suggestion for the future: Include "Fixes #xxx" in the description, where xxx is the issue number. It makes the PR linked to the issue and the issue will be closed automatically when the PR is merged. |
Rename include guard macros (redis -> valkey) and remove the leading double underscore. --------- Signed-off-by: Lipeng Zhu <[email protected]> Signed-off-by: Viktor Söderqvist <[email protected]> Co-authored-by: Viktor Söderqvist <[email protected]>
Rename macro guard and remove the leading double underscore.
Fixes #137