-
Notifications
You must be signed in to change notification settings - Fork 696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new SCRIPT STATS subcommand #1418
base: unstable
Are you sure you want to change the base?
Conversation
Signed-off-by: artikell <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #1418 +/- ##
============================================
+ Coverage 70.85% 70.89% +0.03%
============================================
Files 118 118
Lines 63591 63627 +36
============================================
+ Hits 45058 45108 +50
+ Misses 18533 18519 -14
|
addReplyMapLen(c, 1); | ||
|
||
addReplyBulkCString(c, "running_script"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the thought we will have more stats in the future? I'm wondering if we should just have a command just for the running script, instead of something generic like stats.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be honest, this part is a reference to FUNCTION STATS
.
Currently, there is really only one return value., but as a stat method, it is best to reserve the ability for subsequent extensions.
Alternatively, we can consider adding some Lua-related context, such as Lua execution time/ Lua use Memory, to help users locate problems.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the f$% did the Redis folks do this. I swear they barely thought through functions and then dumped it on the community.
An inspiration is needed to query the execution of the current script. Solve this problem https://github.com/orgs/valkey-io/discussions/1404