pr comments

Signed-off-by: Shoham Elias <[email protected]>
valkey-io · Aug 20, 2024 · ae41490 · ae41490
1 parent 00713ad
commit ae41490
Show file tree

Hide file tree

Showing 8 changed files with 12 additions and 9 deletions.
diff --git a/glide-core/src/client/value_conversion.rs b/glide-core/src/client/value_conversion.rs
@@ -1010,7 +1010,7 @@ fn convert_inner_map_by_type(
     key_type: Option<ExpectedReturnType>,
     value_type: Option<ExpectedReturnType>,
 ) -> RedisResult<Value> {
-    let result: Result<Vec<(Value, Value)>, redis::RedisError> = map
+    let result = map
         .into_iter()
         .map(|(key, inner_value)| {
             Ok((

diff --git a/java/client/src/main/java/glide/api/commands/ScriptingAndFunctionsClusterCommands.java b/java/client/src/main/java/glide/api/commands/ScriptingAndFunctionsClusterCommands.java
@@ -865,7 +865,7 @@ CompletableFuture<ClusterValue<Object>> fcallReadOnly(
     /**
      * Kills a function that is currently executing.<br>
      * <code>FUNCTION KILL</code> terminates read-only functions only.<br>
-     * The command will be routed to all primary nodes.
+     * The command will be routed to all nodes.
      *
      * @since Valkey 7.0 and above.
      * @see <a href="https://valkey.io/commands/function-kill/">valkey.io</a> for details.

diff --git a/java/client/src/main/java/glide/api/commands/ScriptingAndFunctionsCommands.java b/java/client/src/main/java/glide/api/commands/ScriptingAndFunctionsCommands.java
@@ -328,7 +328,8 @@ CompletableFuture<Map<GlideString, Object>[]> functionListBinary(
 
     /**
      * Kills a function that is currently executing.<br>
-     * <code>FUNCTION KILL</code> terminates read-only functions only.
+     * <code>FUNCTION KILL</code> terminates read-only functions only. <code>FUNCTION KILL</code> runs
+     * on all nodes of the server, including primary and replicas.
      *
      * @since Valkey 7.0 and above.
      * @see <a href="https://valkey.io/commands/function-kill/">valkey.io</a> for details.

diff --git a/node/src/GlideClient.ts b/node/src/GlideClient.ts
@@ -597,7 +597,7 @@ export class GlideClient extends BaseClient {
      * Returns information about the function that's currently running and information about the
      * available execution engines.
      *
-     * FUNCTION STATS runs on all nodes of the cluster, including primary and replicas.
+     * FUNCTION STATS runs on all nodes of the server, including primary and replicas.
      * The response includes a mapping from node address to the command response for that node.
      *
      * @see {@link https://valkey.io/commands/function-stats/|valkey.io} for details.
@@ -644,6 +644,7 @@ export class GlideClient extends BaseClient {
     /**
      * Kills a function that is currently executing.
      * `FUNCTION KILL` terminates read-only functions only.
+     * `FUNCTION KILL` runs on all nodes of the server, including primary and replicas.
      *
      * @see {@link https://valkey.io/commands/function-kill/|valkey.io} for details.
      * @remarks Since Valkey version 7.0.0.

diff --git a/node/src/GlideClusterClient.ts b/node/src/GlideClusterClient.ts
@@ -977,7 +977,7 @@ export class GlideClusterClient extends BaseClient {
      * @remarks Since Valkey version 7.0.0.
      *
      * @param route - (Optional) The client will route the command to the nodes defined by `route`.
-     *     If not defined, the command will be routed to all primary nodes.
+     *     If not defined, the command will be routed to all nodes.
      * @returns `OK` if function is terminated. Otherwise, throws an error.
      *
      * @example

diff --git a/python/python/glide/async_commands/cluster_commands.py b/python/python/glide/async_commands/cluster_commands.py
@@ -493,7 +493,7 @@ async def function_kill(self, route: Optional[Route] = None) -> TOK:
         See https://valkey.io/commands/function-kill/ for more details.
 
         Args:
-            route (Optional[Route]): The command will be routed to all primary nodes, unless `route` is provided,
+            route (Optional[Route]): The command will be routed to all nodes, unless `route` is provided,
                 in which case the client will route the command to the nodes defined by `route`.
 
         Returns:

diff --git a/python/python/glide/async_commands/standalone_commands.py b/python/python/glide/async_commands/standalone_commands.py
@@ -374,6 +374,8 @@ async def function_kill(self) -> TOK:
         Kills a function that is currently executing.
         This command only terminates read-only functions.
 
+        FUNCTION KILL runs on all nodes of the server, including primary and replicas.
+
         See https://valkey.io/commands/function-kill/ for more details.
 
         Returns:
@@ -395,7 +397,8 @@ async def function_stats(self) -> TFunctionStatsFullResponse:
         Returns information about the function that's currently running and information about the
         available execution engines.
 
-        FUNCTION STATS runs on all nodes of the cluster, including primary and replicas.  The response includes a mapping from node address to the command response for that node.
+        FUNCTION STATS runs on all nodes of the server, including primary and replicas.
+        The response includes a mapping from node address to the command response for that node.
 
         See https://valkey.io/commands/function-stats/ for more details
 

diff --git a/python/python/tests/test_async_client.py b/python/python/tests/test_async_client.py
@@ -10245,5 +10245,3 @@ async def test_script_large_keys_and_args(self, request, cluster_mode, protocol)
             == key.encode()
         )
         await glide_client.close()
-        await glide_client.close()
-        await glide_client.close()