Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explanation of issues when using GET and NX/XX/IFEQ together in SET command #199

Merged
merged 2 commits into from
Dec 16, 2024

Conversation

soloestoy
Copy link
Member

No description provided.

Copy link
Contributor

@zuiderkwast zuiderkwast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. I have a very small suggestion.

commands/set.md Outdated Show resolved Hide resolved
@zuiderkwast
Copy link
Contributor

I think it's a small disaster that the Reply section is missing on the website version of the docs.

The replies are documented in the files resp2_replies.json and resp3_replies.json. Assuming it will be included on the website some time in the future, we can consider improving this part too.

This is the man page version of the reply section:

REPLY
   RESP2
       Any of the following:

       • valkey-protocol(7) Nil reply: GET not given: Operation was aborted (conflict with one of the XX/NX options).

       • valkey-protocol(7) Simple string reply: OK.  GET not given: The key was set.

       • valkey-protocol(7) Nil reply: GET given: The key didn’t exist before the SET.

       • valkey-protocol(7) Bulk string reply: GET given: The previous value of the key.

   RESP3
       Any of the following:

       • valkey-protocol(7) Null reply: GET not given: Operation was aborted (conflict with one of the XX/NX options).

       • valkey-protocol(7) Simple string reply: OK.  GET not given: The key was set.

       • valkey-protocol(7) Null reply: GET given: The key didn’t exist before the SET.

       • valkey-protocol(7) Bulk string reply: GET given: The previous value of the key.

Co-authored-by: Viktor Söderqvist <[email protected]>
Signed-off-by: zhaozhao.zz <[email protected]>
@soloestoy soloestoy merged commit 387bc9a into valkey-io:main Dec 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants