-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#148 Replaced Master and Slave with Primary and Replica where applicable #177
#148 Replaced Master and Slave with Primary and Replica where applicable #177
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also see a reference in replconf.md
.
In replication.md, we should include references to primaryauth
as the preferred alternative to mastauth
.
All the updates look good, mostly suggesting some additional changes.
…e applicable The labels, commands and command outputs keep master and slave. Added a note about using master and slave to replication page Signed-off-by: Anastasia Alexadrova <[email protected]>
6311dde
to
af26d5f
Compare
Signed-off-by: Madelyn Olson <[email protected]>
@@ -339,7 +339,7 @@ example "write deny-oom". The set of flags are: | |||
Starting from Redis OSS 7.0 this flag has been deprecated. | |||
Declaring a command as "random" can be done using | |||
command tips, see https://valkey.io/topics/command-tips. | |||
* **"allow-stale"**: The command is allowed to run on slaves that don't | |||
* **"allow-stale"**: The command is allowed to run on replicas that don't |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is generated from the various comment blocks in https://github.com/valkey-io/valkey/blob/unstable/src/module.c, so can you also submit a PR to update this file in the main repo as well?
Awesome. Sorry I didn't review this. I just noticed the note "A note about the word slave used in this man page" is on various pages, for example on I did a git grep:
|
@zuiderkwast thanks for raising the question about the disclaimer. I updated these: #180 |
The labels, commands and command outputs keep master and slave. Added a note about using master and slave to replication page