Adding a wrong type error message when performing a bloom operation on a non bloom key #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/bloom/utils.rs
Outdated
| @@ -32,7 +32,7 @@ pub const ENCODE_BLOOM_FILTER_FAILED: &str = "ERR encode bloom filter failed."; | |||
| pub const DECODE_BLOOM_FILTER_FAILED: &str = "ERR decode bloom filter failed."; | |||
| pub const DECODE_UNSUPPORTED_VERSION: &str = | |||
| "ERR decode bloom filter failed. Unsupported version."; | |||
|
|
|||
| pub const WRONG_TYPE_ERROR: &str = "WRONGTYPE Not a BloomFilter key"; | |||
There was a problem hiding this comment.
Could you check what message this returns? Maybe we can use this
https://docs.rs/valkey-module/latest/src/valkey_module/rediserror.rs.html#11
…n a non bloom key Signed-off-by: zackcam <[email protected]>
zackcam
force-pushed
the
WrongType-Change
branch
from
8390266 to
0625fa2
Compare
| @@ -87,7 +87,7 @@ pub fn bloom_filter_add_value( | |||
| let value = match filter_key.get_value::<BloomFilterType>(&BLOOM_FILTER_TYPE) { | |||
| Ok(v) => v, | |||
| Err(_) => { | |||
There was a problem hiding this comment.
The best practice is to handle every case in a match. I understand that the SDK does not make this easy for us because they return a specific string message when an ENUM would have made matching easier.
In the future, if it is possible to update the SDK, we should be able to update our handling to make it stricter.
KarthikSubbarao
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the error on the get_value return to be a WRONG_TYPE_ERROR. Added a test as well checking this happens and the error message is correct for each bloom command.