Adding bloom acl category to commands. Added tests to check that the commands contain the correct acl categories #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ["BF.INFO", bloom_info_command, "readonly fast", 1, 1, 1], | ||
| ["BF.INSERT", bloom_insert_command, "write fast deny-oom", 1, 1, 1], | ||
| ["BF.LOAD", bloom_load_command, "write fast deny-oom", 1, 1, 1] | ||
| ["BF.ADD", bloom_add_command, "write fast deny-oom", 1, 1, 1, "bloom"], |
KarthikSubbarao
approved these changes
Dec 6, 2024
YueTang-Vanessa
approved these changes
Dec 6, 2024
nnmehta
approved these changes
Dec 6, 2024
…commands contain the correct acl categories Signed-off-by: zackcam <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Addressing issue: #11
Currently the dependency for valkey_module doesn't have the change required to create acl categories so the cargo.toml file will be updated once that change is released.Updated dependency of valkey-modules to v0.1.3
Changes in this pr include having to add an 8.0 and 7.2 feature flag as the create_acl_category and set_acl_category methods are behind these flags in the dependency.
For each bloom command we have added a bloom category as well as created the bloom category.
Testing
Testing: There are two tests. We have test that creates two users one with bloom acl category access and one without. We then check that we get the expected behavior when running bloom commands. The other test, checks that acl categories are set correctly for each command. We check that both bloom and other categories are present.