Update common and tests for new common features #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that we switched to gitops-1.11, the helm version is recent enough that we're not affected by the subkey null bug any longer.
Drop old patch around null subkeys
At the time we disabled the `validate-origin` target when running from
inside the container as it apparently caused issues for some folks.
I think now that we run as the user inside the container, the chances of
this not working are reduced, so let's reenable this.
Tested as follows:
❯ ./pattern.sh make TARGET_ORIGIN=upstream validate-origin
Checking repository:
https://github.com/hybrid-cloud-patterns/multicloud-gitops - branch 'nonexisting': NOT FOUND
make: *** [Makefile:12: validate-origin] Error 2
❯ ./pattern.sh make TARGET_ORIGIN=upstream validate-origin
Checking repository:
https://github.com/hybrid-cloud-patterns/multicloud-gitops - branch 'main': OK
❯ ./pattern.sh make validate-origin
Checking repository:
https://github.com/mbaldessari/multicloud-gitops.git - branch 'main': OK
❯ ./pattern.sh make validate-origin
Checking repository:
https://github.com/mbaldessari/multicloud-gitops.git - branch 'nonexisting': NOT FOUND
make: *** [Makefile:12: validate-origin] Error 2
Validate origin inside podman as well
There is no point in testing the requirements when we use the container,
as we guarantee that those exist in there.
Tested as follows:
❯ make validate-prereq
make -f common/Makefile validate-prereq
make[1]: Entering directory '/home/michele/Engineering/cloud-patterns/multicloud-gitops'
Checking prerequisites:
Check for 'git helm oc ansible': OK
Check for python-kubernetes: OK
Check for kubernetes.core collection: OK
make[1]: Leaving directory '/home/michele/Engineering/cloud-patterns/multicloud-gitops'
❯ ./pattern.sh make validate-prereq
make -f common/Makefile validate-prereq
make[1]: Entering directory '/home/michele/Engineering/cloud-patterns/multicloud-gitops'
Skipping prerequisites check as we're running inside a container
make[1]: Leaving directory '/home/michele/Engineering/cloud-patterns/multicloud-gitops'
Run validate-prereq only when not in a container
Bumps [dorny/paths-filter](https://github.com/dorny/paths-filter) from 2 to 3. - [Release notes](https://github.com/dorny/paths-filter/releases) - [Changelog](https://github.com/dorny/paths-filter/blob/master/CHANGELOG.md) - [Commits](dorny/paths-filter@v2...v3) --- updated-dependencies: - dependency-name: dorny/paths-filter dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
…ons/dorny/paths-filter-3 Bump dorny/paths-filter from 2 to 3
k8s secret objects Ensure only push_secrets runs from vault_utils Update makefile - remove extra targets and make fix none Revert version bump as we only add fields Conditionalize check change output Start module to load parsed secrets into vault New machinery for vault secrets loading Make the linters pass again Inject policies Add some more code to test readiness to load Correct typo Add vault_hub Add vaultMount Rename new modules to v2 Update inject_field method Correct field typo Temporarily print command Add more logic Hopefully fix secret loading issue with counter Count per secret Pick stuff out of secret that we need Fix lint issue Refactor tests to use fixture constants Correctly spell exclusion for ansible-lint Provide a target to exercise legacy code path Add error exists for missing args and update docs Reverse test for override Also process base64 for generated secrets Be more explicit about what we load Test framework for loading parsed_secret data Fix linting errors Finish test suite Last linter stuff Change schema; code and tests to follow Add target_namespaces phase 1 more passing, but some still fail Passing again All pass Check the correct variable in golang-external-secrets chart Update YAML parsing to do decodes right Add tests and tighten up code for retrieving block yaml quotes Add test for kubernetes secret object and block yaml
Add support for kubernetes backend for ESO
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.