Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Devspaces #68

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

raffaelespazzoli
Copy link

ok this is my first PR for devspaces.
I totally expect there will some fine tuning.
Let me know what I need to do.

@ipbabble
Copy link
Collaborator

ipbabble commented Mar 16, 2023

Thank you for doing this.
Should devspaces live on the same cluster as the pipelines? I.e. the development cluster? If so we should move the entries in values-hub to values-development. IS there a reason you put it on hub? Was it just for convenience for testing?

@raffaelespazzoli
Copy link
Author

Ideally devspaces should live it it's own cluster, or a cluster that is dedicated to sandboxing user environments. It has not strict relationship with the pipeline cluster. I put in the hub cluster because I was told to do so during the training. @claudiol maybe it was you to tell me so. Did you have a reason?
Anyway we can move it somewhere else.

@day0hero
Copy link
Contributor

@raffaelespazzoli - apologies for the delay on this PR. Could you please move devspaces to development, and then run ./pattern.sh make test ?

It was probably me that said to put it in hub, but it makes more sense to be in devel since we use hub to deploy from ..

thanks!

@beekhof
Copy link
Contributor

beekhof commented Jun 8, 2023

I can see what this does, but not why - though I'm not sure where the best place to keep that information.
Maybe a PR against the docs repo that explains what this component does and how it fits into the architecture?

Should it be deployed by default or just optional?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants