Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grafana #100

Merged
merged 7 commits into from
Jan 10, 2024
Merged

grafana #100

merged 7 commits into from
Jan 10, 2024

Conversation

day0hero
Copy link
Collaborator

  • Updates to Grafana resource object
  • Updated Grafana Dashboards
  • Updated Grafana datasources:
  • updated rbac apiGroups, serviceaccounts for grafana update
  • make test
  • using secretKeyRef vs helm var
  • make test

- Updated Grafana apiGroup
- Modified grafana object container spec
- Added env variables for secret references
- Added route spec for openshift route creation
- Changed ApiGroup
- Updated plugins for dashboards to support latest Grafana version
- spec.instanceSelector now a required field
All:
- Updated apiGroup
- .spec.instanceSelector is now a required field
- kind changed from GrafanaDataSource to GrafanaDatasource

MySQL DataSource:
- Added .spec.valuesFrom to add secretKeyRefs for credential configs

Prometheus Job/DataSource:
- Changed service account from grafana-serviceaccount to
  xraylab-grafana-sa for creating the token
Copy link
Contributor

@claudiol claudiol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@claudiol claudiol merged commit 59ec398 into main Jan 10, 2024
15 checks passed
@day0hero day0hero deleted the grafana branch January 11, 2024 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants