common automatic update #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mbaldessari
commented
Oct 9, 2024
mbaldessari
commented
- Add qe-tests target
- Read PATTERN_INSTALL_CHART from the env as well if it exists
- Update secret backend change script
- Update preview script
- Introduce PATTERN_DISCONNECTED_HOME
- Update Makefile to reflect a warning if no storageclass is present
- Fix iib loading playbook name
Add qe-tests target
Read PATTERN_INSTALL_CHART from the env as well if it exists
The script is used in make secrets-backend-*. Update needed for slimed common.
Now the preview will work with remote charts, and local charts as well. Default helm registry will be oci://quay.io/repository/hybridcloudpatterns/.
Fix scripts after common slim
When doing disconnected installations this allows for setting a single variable pointing to the internal disconnected registry.
Introduce PATTERN_DISCONNECTED_HOME
…quirement Update Makefile to reflect a warning if no storageclass is present
After slimming common down the playbook needs renaming because collections have slightly different naming constraints. Previous error: ❯ ./pattern.sh make load-iib make -f common/Makefile load-iib make[1]: Entering directory '/home/michele/Engineering/cloud-patterns/multicloud-gitops' ERROR! the playbook: rhvp.cluster_utils.iib-ci could not be found make[1]: *** [common/Makefile:117: load-iib] Error 1 make[1]: Leaving directory '/home/michele/Engineering/cloud-patterns/multicloud-gitops' make: *** [Makefile:12: load-iib] Error 2
Fix iib loading playbook name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.