common automatic update #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mbaldessari
commented
Aug 14, 2023
mbaldessari
commented
- Upgrade vault-helm to v0.25.0
- Error out from load-iib when INDEX_IMAGES is undefined
- Add docker.io to the whitelisted registries when loading an IIB
- Fix fetching the bundle name when loading an IIB
- Add retries when getting related images
- Fix up common/ tests
If you call the load-iib target you *must* set INDEX_IMAGES, so
let's error out properly if you do not.
Tested as:
$ unset INDEX_IMAGES
$ make load-iib
make -f common/Makefile load-iib
make[1]: Entering directory '/home/michele/Engineering/cloud-patterns/multicloud-gitops'
No INDEX_IMAGES defined. Bailing out
$ export INDEX_IMAGES=foo
make load-iib
make -f common/Makefile load-iib
make[1]: Entering directory '/home/michele/Engineering/cloud-patterns/multicloud-gitops'
PLAY [IIB CI playbook] ***
Error out from load-iib when INDEX_IMAGES is undefined
Upgrade vault-helm to v0.25.0
Medical diagnosis for example uses docker.io/obsidiandynamics/kafdrop:latest which would be denied by policy.
Add docker.io to the whitelisted registries when loading an IIB
The current -w grep command matches channels even when they are
substrings of each other like for the serverless-operator:
$ podman run -i --rm $INDEX_IMAGES alpha list channels /configs "${OPERATOR}" |grep --word-regexp "stable"
serverless-operator stable serverless-operator.v1.30.0
serverless-operator stable-1.29 serverless-operator.v1.29.1
serverless-operator stable-1.30 serverless-operator.v1.30.0
This then causes error when trying to parse the list of images as we
will have multiple images because we break the one image per line
assumption.
Let's fix this by adding spaces around the grep. Ideall we'd use the
opm render command, but the parsing of all the yaml output seems a bit
much to do for this simple use case.
Fix fetching the bundle name when loading an IIB
I have seen it fail once on a system and it worked on the second run, so let's try a couple of times at least before giving up.
Try harder to fetch related images
mamurak
pushed a commit
to mamurak/industrial-edge
that referenced
this pull request
Sep 20, 2023
Add json schema for the v1 secret format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.