Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanups #333

Merged
merged 4 commits into from
Jul 27, 2023
Merged

Cleanups #333

merged 4 commits into from
Jul 27, 2023

Commits on Jul 27, 2023

  1. Add some more comments in applications.yaml

    @mbaldessari
    mbaldessari committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    dd3cdcb View commit details
    Browse the repository at this point in the history

  2. Add a default for options applicationRetryLimit

    @mbaldessari
    mbaldessari committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    5f33f33 View commit details
    Browse the repository at this point in the history

  3. Split out values files to a helper for the acm chart 

    Just like we did for the clustergroup chart, let's split the values
file list into a dedicated helper. This time since there are no global
variables we include it with the current context and not with the '$'
context.

Tested with MCG: hub and spoke. Correctly observed all the applications
running on the spoke.
    @mbaldessari
    mbaldessari committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    91f3ef0 View commit details
    Browse the repository at this point in the history

  4. Fix up tests 

    They changed because we made the list indentation more correct (two
extra spaces to the left)
    @mbaldessari
    mbaldessari committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    17697e5 View commit details
    Browse the repository at this point in the history