just test

valfirst · Nov 21, 2024 · 7e67435 · 7e67435
1 parent cb2a59e
commit 7e67435
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 4 deletions.
diff --git a/.github/workflows/gradle.yml b/.github/workflows/gradle.yml
@@ -43,3 +43,9 @@ jobs:
       run: |
         export MITMPROXY_BINARY_PATH=$(type -aP mitmdump | xargs dirname )
         ./gradlew build -PMITMPROXY_BINARY_PATH="$MITMPROXY_BINARY_PATH"
+
+    - name: Unit tests
+      uses: actions/upload-artifact@v4
+      if: always()
+      with:
+        path: browserup-proxy-core/build/reports/tests
diff --git a/browserup-proxy-core/src/main/java/com/browserup/bup/mitmproxy/MitmProxyProcessManager.java b/browserup-proxy-core/src/main/java/com/browserup/bup/mitmproxy/MitmProxyProcessManager.java
@@ -5,7 +5,6 @@
 import org.apache.commons.lang3.SystemUtils;
 import org.awaitility.Awaitility;
 import org.awaitility.core.ConditionTimeoutException;
-import org.jetbrains.annotations.NotNull;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
@@ -214,7 +213,7 @@ private void waitForReady() {
     }
   }
 
-  @NotNull
+  // @NotNull
   private ArrayList<String> createCommand(int port, List<AbstractAddon> addons) {
     ArrayList<String> command = new ArrayList<String>() {{
       add(getMitmproxyBinaryPath());

diff --git a/...-proxy-core/src/main/java/com/browserup/bup/mitmproxy/management/AddonsManagerClient.java b/...-proxy-core/src/main/java/com/browserup/bup/mitmproxy/management/AddonsManagerClient.java
@@ -49,8 +49,7 @@ public <T> T requestToAddonsManager(String addOnPath,
                                         String contentType,
                                         Class<T> responseClass) {
         HttpRequest.Builder requestBuilder = HttpRequest.newBuilder()
-                .uri(buildRequestUrl(addOnPath, operation, queryParams))
-                .method(method, requestBody);
+                .uri(buildRequestUrl(addOnPath, operation, queryParams));
 
         if (requestBody != null) {
             requestBuilder.method(method, requestBody).header("Content-Type", contentType);