Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the following limitations:
SeldaT
, ie.SeldaT b (StateT s IO)
did not have aMonadState s
instance,SeldaT
could only be used as outermost element in the transformer stack, ie.StateT s (SeldaT b IO)
did not have aMonadSelda
instance,onException
made it unsafe to use a base monad that uses any form of short-circuiting that is not an exception, ie. ExceptT.Fixing that last point requires using
generalBracket
introduced inexceptions-0.9
, so I had to bump the dependency requirement. I am not sure how this impacts the range of GHC versions that can be supported.Supporting
ExceptT
/MonadError
is rather important for applications based on servant.