-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
autocomplete and import vals #8
Open
jrmann100
wants to merge
8
commits into
val-town:main
Choose a base branch
from
jrmann100:completions
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
d428654
feat: completions MVP with CORS workaround
jrmann100 3a8fb36
refactor: move importVal command to commands
jrmann100 d9c7680
feat: rename command and add setting for version
jrmann100 2ca06ff
fix: trpc endpoints now have CORS
jrmann100 3954c4b
feat: clean up and document completions
jrmann100 d95d5c0
feat: upgrade behavior
jrmann100 65cba04
feat: add autocomplete demo screenshot
jrmann100 dfbed04
docs: update image links, add autocomplete demo
jrmann100 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,95 @@ | ||
import * as vscode from "vscode"; | ||
import { ValtownClient } from "./client"; | ||
|
||
enum ValImportKind { | ||
Default, | ||
Named, | ||
SideEffect, | ||
} | ||
|
||
// TODO: are we hammering the API? should we try to debounce or throttle? | ||
export function registerCompletions( | ||
context: vscode.ExtensionContext, | ||
client: ValtownClient | ||
) { | ||
context.subscriptions.push( | ||
vscode.languages.registerCompletionItemProvider( | ||
{ scheme: "vt+val", language: "typescriptreact" }, | ||
{ | ||
async provideCompletionItems( | ||
document: vscode.TextDocument, | ||
position: vscode.Position | ||
) { | ||
// see if we can match backwards from the cursor to find @[<handle>[/<val>]] | ||
const atImportMatch = /@([a-zA-Z0-9]*)(?:\/([a-zA-Z0-9_]*))?$/.exec( | ||
document.getText( | ||
new vscode.Range( | ||
position.line, | ||
0, | ||
position.line, | ||
position.character | ||
) | ||
) | ||
); | ||
|
||
// if we can't match, don't provide any completions | ||
if (!atImportMatch) { | ||
return []; | ||
} | ||
|
||
const [atImport, typedHandle, name] = atImportMatch; | ||
const startOfAtImport = position.translate(0, -atImport.length); | ||
|
||
// get completions from the API | ||
const data = await client.autocomplete(typedHandle, name); | ||
|
||
return data.map((completionVal) => { | ||
const { handle, name, code, version, exportedName } = completionVal; | ||
let importKind: ValImportKind = ValImportKind.SideEffect; | ||
if (exportedName === "default") { | ||
importKind = ValImportKind.Default; | ||
} else if (exportedName) { | ||
importKind = ValImportKind.Named; | ||
} | ||
|
||
const snippetCompletion = new vscode.CompletionItem({ | ||
label: `@${typedHandle === "me" ? "me" : handle}/${name}`, | ||
detail: ` ${exportedName ?? "(no export)"}`, | ||
description: `v${version}`, | ||
}); | ||
snippetCompletion.documentation = new vscode.MarkdownString( | ||
"```tsx\n" + code + "\n```" | ||
); | ||
let insertText = ""; | ||
if (importKind === ValImportKind.Default) { | ||
insertText = name; | ||
} else if (importKind === ValImportKind.Named) { | ||
insertText = exportedName; | ||
} | ||
snippetCompletion.insertText = insertText; | ||
snippetCompletion.range = new vscode.Range( | ||
startOfAtImport, | ||
position | ||
); | ||
// might not be a function, but we can't tell | ||
snippetCompletion.kind = vscode.CompletionItemKind.Function; | ||
snippetCompletion.command = { | ||
title: "Import Val", | ||
command: "valtown.importVal", | ||
arguments: [ | ||
completionVal, | ||
// this is the range of the replaced text | ||
new vscode.Range( | ||
startOfAtImport, | ||
startOfAtImport.translate(insertText.length) | ||
), | ||
], | ||
}; | ||
return snippetCompletion; | ||
}); | ||
}, | ||
} | ||
// "@", "/" | ||
) | ||
); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Starting to think that this should be true by default for parity with the editor.