Only process versions as a version constraint #110
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a patch is defined with a
level
and asource
, the order of these is important but shouldn't be. When thesource
is defined first, then the patch is applied. However, when thelevel
is defined first, then the patch is not applied. This seems to be related to theLabelVersionConfigComponent
class interpreting the first item in the data array as a constraint. As the value is a number, this passes the "is this a version constraint" test, but because that version constraint doesn't match the installed version of the package, the patch is not applied.Full
composer.json
showing problemThis is my first real pull request for this project. I've not been able to successfully run the test-suite locally. Please can I have some help creating a test for this problem. I'm not confident that this change is the correct way to fix this bug, nor that there are no knock-on effects. I'm hoping that the test-suite runs as expected here, and that I can adjust this pull request based on the results reported, however running the test-suite locally would be best.