feat: introduce proxy clones #115
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces proxy clones to make create `StakeVault`s as cheap as possible. Major changes here are: - Introduce `VaultFactory` which takes care of creating clones and registering them with the stake manager - Make `StakeVault` and `Initializable` so it can be used as a "template" contract to later have proxies point to it - Adjust the deployment script to also deploy `VaultFactory` and ensure The proxy is whitelisted in the stake manager - Make use of the new proxy clones in tests - Add a test for `TrustedCodehashAccess` that ensures the proxy whitelisting works and setting up a (malicious) proxy is not going to work Closes #101
0x-r4bbit
force-pushed
the
feat/clones
branch
from
e812c3d to
9b65913
Compare
0x-r4bbit
requested review from
3esmit and
gravityblast
and removed request for
3esmit
3esmit
reviewed
Feb 3, 2025
3esmit
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces proxy clones to make create
StakeVaults ascheap as possible.
Major changes here are:
VaultFactorywhich takes care of creating clones andregistering them with the stake manager
StakeVaultandInitializableso it can be used as a"template" contract to later have proxies point to it
VaultFactoryand ensureThe proxy is whitelisted in the stake manager
TrustedCodehashAccessthat ensures the proxywhitelisting works and setting up a (malicious) proxy is not going to
work
Closes #101
Checklist
Ensure you completed all of the steps below before submitting your pull request:
pnpm adorno?pnpm verify?