This repository has been archived by the owner on Jun 14, 2024. It is now read-only.
26/WAKU-PAYLOAD #413
Merged
26/WAKU-PAYLOAD #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
D4nte
reviewed
Jul 2, 2021
oskarth
requested review from
D4nte,
jm-clius,
kdeme,
staheri14,
arnetheduck and
cammellos
oskarth
commented
Jul 2, 2021
staheri14
reviewed
Jul 5, 2021
staheri14
reviewed
Jul 6, 2021
oskarth
commented
Jul 6, 2021
D4nte
reviewed
Jul 7, 2021
D4nte
reviewed
Jul 7, 2021
Co-authored-by: Sanaz Taheri Boshrooyeh <[email protected]>
Co-authored-by: Sanaz Taheri Boshrooyeh <[email protected]>
Co-authored-by: Sanaz Taheri Boshrooyeh <[email protected]>
Co-authored-by: Sanaz Taheri Boshrooyeh <[email protected]>
Co-authored-by: Sanaz Taheri Boshrooyeh <[email protected]>
Co-authored-by: Sanaz Taheri Boshrooyeh <[email protected]>
This reverts commit ba496e1.
|
Thanks everyone for your comments! 87 comments, 41 commits and 3 approvals - I'll go ahead and merge this now. If we have further improvements, I suggest we address these in future issues/PRs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #412
This specification describes how Waku provides provides confidentiality, authenticity, and integrity, as well as some form unlinkability.
Specifically, it describes how encryption, decryption and signing works in 6/WAKU1 and in 10/WAKU2 with 14/WAKU-MESSAGE version 1.
This specification effectively replaces 7/WAKU-DATA as well as 6/WAKU1 Payload encryption but written in a way that is agnostic and self-contained for Waku v1 and Waku v2.
Large sections of the specification originate from EIP-627: Whisper spec as well from RLPx Transport Protocol spec (ECIES encryption) with some modifications.
I based this largely on (a) existing specs (b) looking at how nim-eth implements stuff, and a bit at the go-ethereum implementation. I've probably missed something, so a critical eye would be useful here!
Note that this is about documenting existing behavior, not improving it. Improving it based on clear issues would be something for later, but thoughts on this would be welcome. See this issue: #414