Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WAKU2-METADATA: Move to draft #6

Merged
merged 3 commits into from
Apr 17, 2024
Merged

Update WAKU2-METADATA: Move to draft #6

merged 3 commits into from
Apr 17, 2024

Conversation

jimstir
Copy link
Collaborator

@jimstir jimstir commented Feb 25, 2024

Move 66/WAKU2-METADATA to draft.

@jimstir jimstir marked this pull request as draft February 25, 2024 00:56
@jimstir jimstir requested a review from jm-clius March 21, 2024 19:10
@jimstir jimstir marked this pull request as ready for review March 21, 2024 19:10
Copy link
Contributor

@jm-clius jm-clius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. Should we continue maintaining the legacy number here for new draft protocols? No strong opinion on my side, but whereas for filter, store, lightpush, etc. the numbers have become idiomatic, I'm less sure it's the case for some of these later additions.

@jimstir
Copy link
Collaborator Author

jimstir commented Apr 17, 2024

Makes sense to me. Should we continue maintaining the legacy number here for new draft protocols? No strong opinion on my side, but whereas for filter, store, lightpush, etc. the numbers have become idiomatic, I'm less sure it's the case for some of these later additions.

@jm-clius I decided to use the same numbers for the three specs you mentioned should become draft specs before the repo transition. Following specs that migrate from waku/specs will be given new numbers.

@jimstir jimstir merged commit d82eacc into main Apr 17, 2024
1 check passed
@jimstir jimstir deleted the waku-metadata branch April 17, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants